From: Andreas Henriksson <andreas@fatal.se>
Date: Tue, 16 Sep 2014 19:22:59 +0000 (+0200)
Subject: sysv-generator: fix resource leak
X-Git-Tag: v217~551
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=91e7bad45dced1cb2dfaac79337bb08d6e2b74a9;hp=aa9f8a30fd7dc7aa3aa2575b75b3f9a0ab3f02db;p=elogind.git

sysv-generator: fix resource leak

The "unit" string allocation is not freed on either error or success path.

Found by coverity. Fixes: CID#1237755
---

diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c
index 6c3281ff1..e5902ab8f 100644
--- a/src/sysv-generator/sysv-generator.c
+++ b/src/sysv-generator/sysv-generator.c
@@ -114,9 +114,9 @@ static int add_symlink(const char *service, const char *where) {
 }
 
 static int generate_unit_file(SysvStub *s) {
-        char *unit;
         char **p;
         _cleanup_fclose_ FILE *f = NULL;
+        _cleanup_free_ char *unit = NULL;
         _cleanup_free_ char *before = NULL;
         _cleanup_free_ char *after = NULL;
         _cleanup_free_ char *wants = NULL;