From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 10 Jan 2021 21:49:51 +0000 (+0000)
Subject: mgmtchanne: More helpfully report errors from AlterGame insns
X-Git-Tag: otter-0.3.0~106
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=83ff547e695cf85d85eb7b37d330a2875d9fcf03;p=otter.git

mgmtchanne: More helpfully report errors from AlterGame insns

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/mgmtchannel.rs b/src/mgmtchannel.rs
index efa0b772..41b87e04 100644
--- a/src/mgmtchannel.rs
+++ b/src/mgmtchannel.rs
@@ -74,7 +74,14 @@ impl MgmtChannel {
           format!("got error response to: {:?}",&cmd)
         )?;
       },
-      AlterGame { error: Some(error), .. } => {
+      AlterGame { error: Some(error), ref responses } => {
+        if let MgmtCommand::AlterGame { insns, .. } = &cmd {
+          if responses.len() < insns.len() {
+            Err(error.clone())
+              .context("AlterGame insn failed")
+              .with_context(|| format!(" {:?}", &insns[responses.len()]))?;
+          }
+        }
         Err(error.clone()).context(format!(
           "game alterations failed (maybe partially); response to: {:?}",
           &cmd