From: Daniel Martí <mvdan@mvdan.cc>
Date: Fri, 22 May 2015 07:33:15 +0000 (+0200)
Subject: lint: be more strict about redundant summaries
X-Git-Tag: 0.4.0~67
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=7b0e8bd01d8b034bcafb9bc80d839f95fcbf0fe2;p=fdroidserver.git

lint: be more strict about redundant summaries
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 8b9139b5..55722506 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -81,6 +81,10 @@ regex_warnings = {
     'Summary': [
         (re.compile(r'^$'),
          "Summary yet to be filled"),
+        (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
+         "No need to specify that the app is Free Software"),
+        (re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
+         "No need to specify that the app is for Android"),
     ],
     'Description': [
         (re.compile(r'^No description available$'),
@@ -114,8 +118,6 @@ regex_pedantic = {
          "/issues is often enough on its own"),
     ],
     'Summary': [
-        (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
-         "No need to specify that the app is Free Software"),
         (re.compile(r'.*[a-z0-9][.!?][ $]'),
          "Punctuation should be avoided"),
     ],