From: Michael Marineau <michael.marineau@coreos.com>
Date: Mon, 21 Jul 2014 23:23:42 +0000 (-0700)
Subject: networkd: fix reporting errors from hostnamed
X-Git-Tag: v216~394
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=70b34f5de86809991d6753ba486b88481ceab817;hp=ea917db9e662ae6e6d0ae07e0118b323688c8616;p=elogind.git

networkd: fix reporting errors from hostnamed

The return value may be -EINVAL or a positive errno from the dbus
message. Check both ranges, otherwise most errors are silently ignored.
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 3b8b7ed80..7db71c0b7 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -835,7 +835,9 @@ static int set_hostname_handler(sd_bus *bus, sd_bus_message *m, void *userdata,
 
         r = sd_bus_message_get_errno(m);
         if (r < 0)
-                log_warning_link(link, "Could not set hostname: %s", strerror(-r));
+                r = -r;
+        if (r > 0)
+                log_warning_link(link, "Could not set hostname: %s", strerror(r));
 
         return 1;
 }