From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 16 Jul 2016 10:53:08 +0000 (+0100)
Subject: Split brain: Do not leave STDOUT redirected to /dev/null (!)
X-Git-Tag: archive/debian/2.0~277
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=5d84e41a236c4e53e12e02418b5ef2d17acb3a2e;p=dgit.git

Split brain: Do not leave STDOUT redirected to /dev/null (!)

We use runcmd shell_cmd for gbp pq import, and the other commands not
produce undesirable output.
---

diff --git a/dgit b/dgit
index 455b375e..66349e45 100755
--- a/dgit
+++ b/dgit
@@ -2594,7 +2594,6 @@ sub quiltify_splitbrain ($$$$$$) {
 	($diffbits->{O2A} & 01)) { # some patches
 	quiltify_splitbrain_needed();
 	progress "creating patches-applied version using gbp pq";
-	open STDOUT, ">/dev/null" or die $!;
 	runcmd shell_cmd 'exec >/dev/null', @gbp, qw(pq import);
 	# gbp pq import creates a fresh branch; push back to dgit-view
 	runcmd @git, qw(update-ref refs/heads/dgit-view HEAD);