From: Lennart Poettering <lennart@poettering.net>
Date: Sun, 31 Jul 2011 23:18:33 +0000 (+0200)
Subject: util: optimize strstrip() a bit
X-Git-Tag: v33~32
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=57a8eca84a1eda99c8cfb63889fa300ba982cb77;p=elogind.git

util: optimize strstrip() a bit
---

diff --git a/src/util.c b/src/util.c
index cbfac6ec3..1a61a2604 100644
--- a/src/util.c
+++ b/src/util.c
@@ -1411,21 +1411,18 @@ int reset_all_signal_handlers(void) {
 }
 
 char *strstrip(char *s) {
-        char *e, *l = NULL;
+        char *e;
 
         /* Drops trailing whitespace. Modifies the string in
          * place. Returns pointer to first non-space character */
 
         s += strspn(s, WHITESPACE);
 
-        for (e = s; *e; e++)
-                if (!strchr(WHITESPACE, *e))
-                        l = e;
+        for (e = strchr(s, 0); e > s; e --)
+                if (!strchr(WHITESPACE, e[-1]))
+                        break;
 
-        if (l)
-                *(l+1) = 0;
-        else
-                *s = 0;
+        *e = 0;
 
         return s;
 }