From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 12 Nov 2020 22:09:09 +0000 (+0000)
Subject: sort out some todo plans
X-Git-Tag: otter-0.2.0~530
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=53287798216d1dc0e66c511adc55e395e37f4789;p=otter.git

sort out some todo plans

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/accounts.rs b/src/accounts.rs
index e90c6b43..d0039d7a 100644
--- a/src/accounts.rs
+++ b/src/accounts.rs
@@ -224,6 +224,7 @@ impl AccessRecord {
 }
 
 impl From<Box<dyn PlayerAccessSpec>> for AccessRecord {
+  // xxx get rid of this From impl and do a server permission check
   fn from(spec: Box<dyn PlayerAccessSpec>) -> Self { Self(spec.into()) }
 }
 
diff --git a/src/spec.rs b/src/spec.rs
index aa75aa14..a545a9ae 100644
--- a/src/spec.rs
+++ b/src/spec.rs
@@ -314,7 +314,6 @@ pub mod implementation {
   #[typetag::serde(tag="access")]
   pub trait PlayerAccessSpec : Debug + Sync + Send {
     fn override_token(&self) -> Option<&RawToken> {
-      // xxx check this on setting access
       None
     }
     fn server_deliver<'t>(&self,