From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 15 May 2022 14:22:54 +0000 (+0100)
Subject: subst: Use ${...} format internally for most things
X-Git-Tag: otter-1.1.0~107
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=4bd2880a184dfcf5a77ebdced83afd92e2625a16;p=otter.git

subst: Use ${...} format internally for most things

This saves allocating in the usual case and is also clearer.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/shapelib.rs b/src/shapelib.rs
index a7fe6f0f..0d80ff81 100644
--- a/src/shapelib.rs
+++ b/src/shapelib.rs
@@ -1308,7 +1308,7 @@ fn process_files_entry(
         src, item_name, src_name.as_deref(),
       )?;
       let desc = Substituting::new(mformat, Dollars::Text, &fe.desc);
-      let desc = subst(desc, "_colour", "")?.finish()?.to_html();
+      let desc = subst(desc, "${colour}", "")?.finish()?.to_html();
       OccData::Internal(Arc::new(OccData_Internal {
         item_name,
         loaded: default(),
@@ -1413,7 +1413,7 @@ fn process_files_entry(
     let desc = if let Some(desc_template) = &group.d.desc_template {
       let desc_template = Substituting::new(
         mformat, Dollars::Text, desc_template);
-      subst(desc_template, "_desc", &desc.nest()?)?.finish()?.to_html()
+      subst(desc_template, "${desc}", &desc.nest()?)?.finish()?.to_html()
     } else {
       desc.finish()?.to_html()
     };
@@ -1440,11 +1440,11 @@ fn process_files_entry(
         mformat, &magic.item_prefix, &fe, &magic.item_suffix)?)?;
 
       let spec = Substituting::new(mformat, Dollars::Text, &magic.template);
-      let spec = substn(spec, "_image", &image_table)?;
+      let spec = substn(spec, "${image}", &image_table)?;
       let mut spec = c_colour_all(spec.into())?.is_y()?;
       for (k,v) in &fe.extra_fields {
         if k.starts_with('x') {
-          spec = substn(spec, format!("_{}", k), v)?;
+          spec = substn(spec, format!("${{{}}}", k), v)?;
         }
       }
       let spec = spec.finish()?;
@@ -1470,7 +1470,7 @@ fn process_files_entry(
     add1(None, None)?;
   } else {
     for (colour, recolourdata) in &group.d.colours {
-      add1(Some(("_colour", colour)),
+      add1(Some(("${colour}", colour)),
            Some(("_c", &recolourdata.abbrev)))?;
     }
   }