From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Tue, 27 May 2025 21:26:27 +0000 (+0100)
Subject: toolbox-inserts: UniversalJoint: fix walls taller
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=49dac1e1c8f20d0828836b059224662a4909e452;p=reprap-play.git

toolbox-inserts: UniversalJoint: fix walls taller

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/toolbox-inserts.scad b/toolbox-inserts.scad
index 13a026e..7a892e3 100644
--- a/toolbox-inserts.scad
+++ b/toolbox-inserts.scad
@@ -179,7 +179,8 @@ module WellSurround(
   fixings,
   // offset=[x,y] moves the whole thing by that amount, but not the fixings
   offset=[0,0],
-  wall=well_surround_wall
+  wall=well_surround_wall,
+  walls_taller=0
 ) {
 
   dz = box_main_z - below_plane_z - half_height;
@@ -187,7 +188,7 @@ module WellSurround(
   render() difference(){
     difference(){
       union(){
-	translate(concat(offset, [0])) linextr(-10, dz){
+	translate(concat(offset, [0])) linextr(-10, dz + walls_taller){
 	  offset($fn=8, r = wall)
 	    projection(cut=false)
 	    let($well_surround_cutout_only = false)
@@ -208,7 +209,11 @@ module WellSurround(
 
       translate(concat(offset, [0])) translate([0, 0, dz]) {
 	let($well_surround_cutout_only = true)
-	children(0);
+	  children(0);
+	linextr(0, walls_taller+1)
+	  projection(cut=false)
+	  let($well_surround_cutout_only = false)
+	  children(0);
       }
 
       translate(concat(offset, [0])) for (gap=gaps) {
@@ -532,14 +537,12 @@ module UniversalJointPositive() { ////toplevel
 }
 module UniversalJointHolder() { ////toplevel
   WellSurround(
-    half_height = universal_joint_d_fat/2 - universal_joint_deeper,
+    half_height = universal_joint_d_fat/2,
     gaps = [],
-    fixings = []
+    fixings = [],
+    walls_taller = universal_joint_deeper
   ) {
-    for (dz = [0, ]) {
-      translate([0, 0, -universal_joint_deeper])
-	UniversalJointPositive();
-    }
+    UniversalJointPositive();
   }
 }