From: Ciaran Gultnieks <ciaran@ciarang.com>
Date: Wed, 11 May 2011 21:22:46 +0000 (+0100)
Subject: Don't allow duplicate version codes
X-Git-Tag: 0.1~1392
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=1ef0b0ca092b9e5736fc7f7b707d9e6a251cd57e;p=fdroidserver.git

Don't allow duplicate version codes
---

diff --git a/update.py b/update.py
index bd7e0acf..12f2fc8d 100755
--- a/update.py
+++ b/update.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-
 #
 # update.py - part of the FDroid server tools
-# Copyright (C) 2010, Ciaran Gultnieks, ciaran@ciarang.com
+# Copyright (C) 2010-11, Ciaran Gultnieks, ciaran@ciarang.com
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License as published by
@@ -328,6 +328,14 @@ for app in apps:
             # doesn't have to do any work by default...
             apklist = sorted(apklist, key=lambda apk: apk['versioncode'], reverse=True)
 
+            # Check for duplicates - they will make the client unhappy...
+            for i in range(len(apklist) - 1):
+                if apklist[i]['versioncode'] == apklist[i+1]['versioncode']:
+                    print "ERROR - duplicate versions"
+                    print apklist[i]['apkname']
+                    print apklist[i+1]['apkname']
+                    sys.exit(1)
+
             for apk in apklist:
                 apkel = doc.createElement("package")
                 apel.appendChild(apkel)