From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 13 Oct 2018 12:31:52 +0000 (+0100)
Subject: dgit: Demand that all clean modes are handled by clean_tree_check
X-Git-Tag: archive/debian/8.0~10
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=1d5fcc08324200339c57ab8c6cac1c8ad9e9943a;p=dgit.git

dgit: Demand that all clean modes are handled by clean_tree_check

We've dealt with all the cases now, so we can add the default.

Also, in the test suite.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/dgit b/dgit
index f5092f5d..e1048389 100755
--- a/dgit
+++ b/dgit
@@ -6243,6 +6243,8 @@ sub clean_tree_check () {
 	# deleted.  Since we're not, and not using the working tree
 	# anyway, we can just ignore them - nothing will use them.
     } elsif ($cleanmode eq 'none') {
+    } else {
+	confess "$cleanmode ?";
     }
 }
 
diff --git a/tests/lib-build-modes b/tests/lib-build-modes
index 78ae236f..bc8b2aa8 100644
--- a/tests/lib-build-modes
+++ b/tests/lib-build-modes
@@ -161,7 +161,6 @@ bm-compute-expected () {
 	none|Cnone)	;;
 	Cdpkg-source*)	;; # handled below
 	Cgit|Cgit-ff)	;;
-	C*)		echo "TODO bm eff_cleanmode=$eff_cleanmode" ;;
 	*)		fail "t-compute-expected-run $cleanmode ??" ;;
 	esac