From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri, 19 Mar 2021 01:27:25 +0000 (+0000)
Subject: clock: Some todos
X-Git-Tag: otter-0.5.0~641
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=0ffa159f6cc3fc186af19a5f58268eb0edfbe13e;p=otter.git

clock: Some todos

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/clock.rs b/src/clock.rs
index 7e2b39c8..8250a2c9 100644
--- a/src/clock.rs
+++ b/src/clock.rs
@@ -425,18 +425,19 @@ impl PieceTrait for Clock {
           ust.remaining = self.spec.initial_time();
         }
       },
-      "claim-x" | "claim-y" => {
+      "claim-x" | "claim-y" => { // xxx these need to be Unpredictable
         let user = get_user();
         if let Some(_gpl) = gs.players.get(state.users[user].player) {
           throw!(OE::BadPieceStateForOperation);
         }
         if state.users[! user].player == player {
           // todo: some more useful per-player message
+          // xxx: actually, clear us from the other player instead ?
           throw!(OE::BadPieceStateForOperation);
         }
         state.users[user].player = player;
       },
-      "unclaim-x" | "unclaim-y" => {
+      "unclaim-x" | "unclaim-y" => { // xxx these need to be Unpredictable
         let user = get_user();
         if state.users[user].player != player {
           throw!(OE::BadPieceStateForOperation);