From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 31 Mar 2022 00:18:22 +0000 (+0100)
Subject: clippy: Miscellaneous minor changes, and allow lints
X-Git-Tag: otter-1.0.0~52
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=09fa8e17351a881d7e3f9c5f7f38d2693995cfdb;p=otter.git

clippy: Miscellaneous minor changes, and allow lints

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/clippy-options b/clippy-options
index e7ab1003..3586d41d 100644
--- a/clippy-options
+++ b/clippy-options
@@ -16,3 +16,6 @@
 -A clippy::single_match
 -A clippy::too_many_arguments # yes, I know
 -A clippy::never_loop # control flow bodge
+-A clippy::needless_splitn
+-A clippy::type_complexity
+-A clippy::redundant_closure
diff --git a/src/bundles.rs b/src/bundles.rs
index 390b4a41..d59d1276 100644
--- a/src/bundles.rs
+++ b/src/bundles.rs
@@ -1060,7 +1060,7 @@ impl InstanceBundles {
       IE
       >>
   {
-    let bd = b_dir(&instance);
+    let bd = b_dir(instance);
     let mo = glob::MatchOptions {
       require_literal_leading_dot: true,
       ..default()
diff --git a/src/clock.rs b/src/clock.rs
index 2845431e..af8fc00a 100644
--- a/src/clock.rs
+++ b/src/clock.rs
@@ -412,7 +412,7 @@ impl PieceSpec for Spec {
       spec: self.clone(),
     };
 
-    gpc.xdata_mut(|| State::new(&self) )?;
+    gpc.xdata_mut(|| State::new(self) )?;
 
     PieceSpecLoaded {
       p: Box::new(clock),
@@ -442,7 +442,7 @@ impl PieceTrait for Clock {
                vpid: VisiblePieceId) {
     let state = gpc.xdata()?
       .ok_or_else(|| internal_logic_error("missing/wrong xdata"))?;
-    let urenders = self.urender(&state, gpc.held, &gs.players);
+    let urenders = self.urender(state, gpc.held, &gs.players);
 
     // player missing, nick is red and pink
 
@@ -491,10 +491,7 @@ impl PieceTrait for Clock {
       let mins = u.remaining.tv_sec() / 60;
       let secs = u.remaining.tv_sec() % 60;
       let mins = mins.to_string();
-      let mins_pad = Html::from_html_string(
-        iter::repeat("&nbsp;").take(3 - mins.len())
-          .collect()
-      );
+      let mins_pad = Html::from_html_string("&nbsp;".repeat(3 - mins.len()));
 
       let pointer = Html::lit(r##"
   pointer-events="none"