From: Ian Jackson Date: Wed, 19 Oct 2016 21:54:47 +0000 (+0100) Subject: Dgit.pm: failedcmd_report_cmd: Break out of failedcmd X-Git-Tag: archive/debian/2.6~2 X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;ds=sidebyside;h=3c607d65d5675be05fb41f87fd74cd3a00016b65;p=dgit.git Dgit.pm: failedcmd_report_cmd: Break out of failedcmd No functional change. Signed-off-by: Ian Jackson --- diff --git a/Debian/Dgit.pm b/Debian/Dgit.pm index 5c43f025..6854a7cf 100644 --- a/Debian/Dgit.pm +++ b/Debian/Dgit.pm @@ -41,7 +41,7 @@ BEGIN { stat_exists link_ltarget hashfile fail ensuredir executable_on_path - waitstatusmsg failedcmd + waitstatusmsg failedcmd_report_cmd failedcmd cmdoutput cmdoutput_errok git_rev_parse git_get_ref git_for_each_ref git_for_each_tag_referring is_fast_fwd @@ -217,6 +217,12 @@ sub waitstatusmsg () { } } +sub failedcmd_report_cmd { + my $intro = shift @_; + $intro //= "failed command"; + { local ($!); printcmd \*STDERR, _us().": $intro:", @_ or die $!; }; +} + sub failedcmd { # Expects $!,$? as set by close - see below. # To use with system(), set $?=-1 first. @@ -229,7 +235,7 @@ sub failedcmd { # success trashed $?==0 system # program failed trashed $? >0 system # syscall failure $! >0 unchanged system - { local ($!); printcmd \*STDERR, _us().": failed command:", @_ or die $!; }; + failedcmd_report_cmd undef, @_; if ($? < 0) { fail "failed to fork/exec: $!"; } elsif ($?) {