This fires on process_all_players_for_account, but the collect
*is* needed and the suggestion doesn't compile.
I wasn't able to make a minimal repro, but there is what looks like a
report of the same thing (and many other issues with this lint).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
-A clippy::len_zero
-A clippy::len_without_is_empty # I prefer comparing .len() to 0, apparently
-A clippy::blocks_in_if_conditions
+-A clippy::needless_collect # rust-clippy/issues/8046, since Nov 2021 at least