chiark / gitweb /
hidden prep: api_wrest: Move was formatting earlier
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 31 Jan 2021 21:11:18 +0000 (21:11 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 31 Jan 2021 22:21:44 +0000 (22:21 +0000)
We want to drop the borrow on gs.players.get(was) because we will want
a mut borrow of gs.players soon.

NFC

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
daemon/api.rs

index 4a3291f3218ead812f1ad0dfce0a50418c2af8d4..08dd25ce0bfa241ef66778c0f94c4e56d22f5ec8 100644 (file)
@@ -256,14 +256,14 @@ api_route!{
     let was = pc.held;
     pc.held = Some(player);
     let was = was.and_then(|p| gs.players.get(p));    
+    let was = was.map(|was| htmlescape::encode_minimal(&was.nick));
 
     let update = PieceUpdateOp::Modify(());
 
     let pls = &htmlescape::encode_minimal(&gpl.nick);
 
     let logent = LogEntry { html : Html(match was {
-        Some(was) => format!("{} wrested {} from {}", pls, pcs,
-                             &htmlescape::encode_minimal(&was.nick)),
+        Some(was) => format!("{} wrested {} from {}", pls, pcs, was),
         None => format!("{} wrested {}", pls, pcs),
     })};