currency: Many fixes to splitting

This was quite broken.

* Actually set the value of the new (change) piece.
* Set the value of tghe taken piece correctly.
* Set the WRC so that clients see the taken piece value.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

diff --git a/src/currency.rs b/src/currency.rs
index b381cb28ec1ade30bf2e24a0e18314773e330c4e..2b3ef97e435c2ac68a50c9687e55a32a7f295623 100644 (file)
--- a/src/currency.rs
+++ b/src/currency.rs
@@ -139,11 +139,12 @@ impl PieceTrait for Banknote {
     let remaining = tgpc_value.qty.checked_sub(take)
       .ok_or(Ia::CurrencyShortfall)?;
 
-    ngpc.xdata_init(Value { qty: take })?;
+    tgpc_value.qty = take;
+    ngpc.xdata_init(Value { qty: remaining })?;
 
     tgpc.held = Some(player);
     ngpc.held = None;
-
+    
     tgpc.pinned = false;
 
     let logents = log_did_to_piece(
@@ -156,7 +157,7 @@ impl PieceTrait for Banknote {
     let update = PieceUpdateOp::ModifyQuiet(());
 
     Ok((
-      (WhatResponseToClientOp::Predictable,
+      (WhatResponseToClientOp::UpdateSvg,
        update,
        logents).into(),
       default()