chiark / gitweb /
js: Centralise piece_set_pos_core
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 3 Apr 2021 17:13:32 +0000 (18:13 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 4 Apr 2021 19:07:53 +0000 (20:07 +0100)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
templates/script.ts

index b32b36f752c2ec82646c3b376a76c1d1b5969f62..4c5c1638fe5a428b8f8f2a1e8f5b4007e070e0ac 100644 (file)
@@ -897,8 +897,7 @@ function drag_mousemove(e: MouseEvent) {
        tp.held == us &&
        occregions.contains_pos(x,y) != tp.held_us_inoccult
       );
-      tp.uelem.setAttributeNS(null, "x", x+"");
-      tp.uelem.setAttributeNS(null, "y", y+"");
+      piece_set_pos_core(tp, x, y);
       tp.queued_moves++;
       api_piece(api_delay, 'm', tpiece,tp, [x, y] );
       if (need_redisplay_ancillaries) redisplay_ancillaries(tpiece, tp);
@@ -1286,6 +1285,11 @@ function piece_modify(piece: PieceId, p: PieceInfo, info: PreparedPieceState,
   piece_modify_core(piece, p, info, conflict_expected);
 }
                       
+function piece_set_pos_core(p: PieceInfo, x: number, y: number) {
+  p.uelem.setAttributeNS(null, "x", x+"");
+  p.uelem.setAttributeNS(null, "y", y+"");
+}
+
 function piece_modify_core(piece: PieceId, p: PieceInfo,
                           info: PreparedPieceState,
                           conflict_expected: boolean) {
@@ -1404,9 +1408,7 @@ pieceops.Move = <PieceHandler>function
 (piece,p, info: Pos ) {
   piece_checkconflict_nrda(piece,p,false);
   piece_note_moved(piece, p);
-
-  p.uelem.setAttributeNS(null, "x", info[0]+"");
-  p.uelem.setAttributeNS(null, "y", info[1]+"");
+  piece_set_pos_core(p, info[0], info[1]);
 }
 
 pieceops.SetZLevel = <PieceHandler>function