chiark / gitweb /
lib enquiries: Some todos
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 15 May 2021 16:30:24 +0000 (17:30 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 15 May 2021 16:30:24 +0000 (17:30 +0100)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
src/bin/otter.rs
src/mgmtchannel.rs

index 7d58b497a3ffae9ad527b9c75389a0699d242033..9eba6f2c8b489825104b71becb21a0df7415f58f 100644 (file)
@@ -984,8 +984,10 @@ impl LibGlobArgs {
     ap: &'_ mut ArgumentParser<'ap>
   ) {
     use argparse::*;
+    // xxx allow lack of library name to list library names
     ap.refer(&mut self.pat.lib).required()
       .add_argument("LIB-NAME",Store,"library name");
+    // xxx allow lack of pattern to list whole library
     ap.refer(&mut self.pat.item).required()
       .add_argument("ITEM-GLOB-PATTERN",Store,"item glob pattern");
   }
index c5668cc1d7b57c9221c48efb2d640ae888932b1c..54f5561959b4d472e2e5a75a940f217618e794bc 100644 (file)
@@ -125,6 +125,7 @@ impl MgmtChannel {
   #[throws(AE)]
   pub fn list_items(&mut self, pat: &shapelib::ItemSpec)
                 -> Vec<shapelib::ItemEnquiryData> {
+    // xxx allow globbing of library names
     let cmd = MgmtCommand::LibraryListByGlob { glob: pat.clone() };
     let mut items = match self.cmd(&cmd)? {
       MgmtResponse::LibraryItems(items) => items,