chiark / gitweb /
Add summary-related lint warnings
authorDaniel Martí <mvdan@mvdan.cc>
Fri, 18 Apr 2014 18:54:44 +0000 (20:54 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 18 Apr 2014 18:54:44 +0000 (20:54 +0200)
fdroidserver/lint.py

index 13479286908538d5a4ee537ce9d9b21670715ae6..7d36c612c7442d1bbd659781fc4d6823ffffdabd 100644 (file)
@@ -170,6 +170,18 @@ def main():
             warn("Summary of length %s is over the %i char limit" % (
                 summ_chars, config['char_limits']['Summary']))
 
+        # Redundant summaries
+        summary = app['Summary']
+        name = str(app['Name'] if app['Name'] else app['Auto Name'])
+        if summary and name:
+            summary_l = summary.lower()
+            name_l = name.lower()
+            if summary_l == name_l:
+                warn("Summary '%s' is just the app's name" % summary)
+            elif (summary_l in name_l or name_l in summary_l):
+                pwarn("Summary '%s' probably contains redundant info of app name '%s'" % (
+                    summary, name))
+
         # Invalid lists
         desc_chars = 0
         for line in app['Description']: