X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=udev_rules.c;h=ea850a84c339a90712ff89c792b8d987b3ba1322;hb=ad1be3e7ad01b263312eaf2a06db0c24c9c90441;hp=55a079be8746f01eadb222cf02dfe8e1f8f9bc2a;hpb=bf50425b58da6f112197f79241dd6d64af2e9ea7;p=elogind.git

diff --git a/udev_rules.c b/udev_rules.c
index 55a079be8..ea850a84c 100644
--- a/udev_rules.c
+++ b/udev_rules.c
@@ -528,35 +528,40 @@ int udev_rules_run(struct udevice *udev)
 }
 
 #define WAIT_LOOP_PER_SECOND		50
-static int wait_for_sysfs(struct udevice *udev, const char *file, int timeout)
+static int wait_for_file(struct udevice *udev, const char *file, int timeout)
 {
-	char devicepath[PATH_SIZE];
 	char filepath[PATH_SIZE];
+	char devicepath[PATH_SIZE] = "";
 	struct stat stats;
 	int loop = timeout * WAIT_LOOP_PER_SECOND;
 
-	strlcpy(devicepath, sysfs_path, sizeof(devicepath));
-	strlcat(devicepath, udev->dev->devpath, sizeof(devicepath));
-	strlcpy(filepath, devicepath, sizeof(filepath));
-	strlcat(filepath, "/", sizeof(filepath));
-	strlcat(filepath, file, sizeof(filepath));
+	/* a relative path is a device attribute */
+	if (file[0] != '/') {
+		strlcpy(devicepath, sysfs_path, sizeof(devicepath));
+		strlcat(devicepath, udev->dev->devpath, sizeof(devicepath));
 
-	dbg("will wait %i sec for '%s'\n", timeout, filepath);
+		strlcpy(filepath, devicepath, sizeof(filepath));
+		strlcat(filepath, "/", sizeof(filepath));
+		strlcat(filepath, file, sizeof(filepath));
+		file = filepath;
+	}
+
+	dbg("will wait %i sec for '%s'\n", timeout, file);
 	while (--loop) {
 		/* lookup file */
-		if (stat(filepath, &stats) == 0) {
-			info("file '%s' appeared after %i loops\n", filepath, (timeout * WAIT_LOOP_PER_SECOND) - loop-1);
+		if (stat(file, &stats) == 0) {
+			info("file '%s' appeared after %i loops\n", file, (timeout * WAIT_LOOP_PER_SECOND) - loop-1);
 			return 0;
 		}
 		/* make sure, the device did not disappear in the meantime */
-		if (stat(devicepath, &stats) != 0) {
-			info("device disappeared while waiting for '%s'\n", filepath);
+		if (devicepath[0] != '\0' && stat(devicepath, &stats) != 0) {
+			info("device disappeared while waiting for '%s'\n", file);
 			return -2;
 		}
-		info("wait for '%s' for %i mseconds\n", filepath, 1000 / WAIT_LOOP_PER_SECOND);
+		info("wait for '%s' for %i mseconds\n", file, 1000 / WAIT_LOOP_PER_SECOND);
 		usleep(1000 * 1000 / WAIT_LOOP_PER_SECOND);
 	}
-	info("waiting for '%s' failed\n", filepath);
+	info("waiting for '%s' failed\n", file);
 	return -1;
 }
 
@@ -1096,7 +1101,7 @@ static int match_rule(struct udevice *udev, struct udev_rule *rule)
 		attr_subst_subdir(filename, sizeof(filename));
 
 		match = (stat(filename, &statbuf) == 0);
-		info("'%s' %s", filename, match ? "exists" : "does not exist\n");
+		info("'%s' %s", filename, match ? "exists\n" : "does not exist\n");
 		if (match && rule->test_mode_mask > 0) {
 			match = ((statbuf.st_mode & rule->test_mode_mask) > 0);
 			info("'%s' has mode=%#o and %s %#o\n", filename, statbuf.st_mode,
@@ -1110,11 +1115,14 @@ static int match_rule(struct udevice *udev, struct udev_rule *rule)
 		dbg("TEST key is true\n");
 	}
 
-	if (rule->wait_for_sysfs.operation != KEY_OP_UNSET) {
+	if (rule->wait_for.operation != KEY_OP_UNSET) {
+		char filename[PATH_SIZE];
 		int found;
 
-		found = (wait_for_sysfs(udev, key_val(rule, &rule->wait_for_sysfs), 10) == 0);
-		if (!found && (rule->wait_for_sysfs.operation != KEY_OP_NOMATCH))
+		strlcpy(filename, key_val(rule, &rule->wait_for), sizeof(filename));
+		udev_rules_apply_format(udev, filename, sizeof(filename));
+		found = (wait_for_file(udev, filename, 10) == 0);
+		if (!found && (rule->wait_for.operation != KEY_OP_NOMATCH))
 			goto nomatch;
 	}
 
@@ -1412,7 +1420,10 @@ int udev_rules_get_name(struct udev_rules *rules, struct udevice *udev)
 			if (!udev->mode_final && rule->mode.operation != KEY_OP_UNSET) {
 				if (rule->mode.operation == KEY_OP_ASSIGN_FINAL)
 					udev->mode_final = 1;
-				udev->mode = strtol(key_val(rule, &rule->mode), NULL, 8);
+				char buf[20];
+				strlcpy(buf, key_val(rule, &rule->mode), sizeof(buf));
+				udev_rules_apply_format(udev, buf, sizeof(buf));
+				udev->mode = strtol(buf, NULL, 8);
 				dbg("applied mode=%#o to '%s'\n", udev->mode, udev->dev->kernel);
 			}
 			if (!udev->owner_final && rule->owner.operation != KEY_OP_UNSET) {