X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=udev%2Fudev-event.c;h=4b00cab30d1f989b3b542a8e7ae6159b8cf28c68;hb=9032f119f07ad3b5116b3d4858816d851d4127de;hp=9e82f8de42f1baaf7ae2cfd29972b31cbe14a8af;hpb=3d7b2831cd661afd7d946791110b6ad5a7156d7f;p=elogind.git

diff --git a/udev/udev-event.c b/udev/udev-event.c
index 9e82f8de4..4b00cab30 100644
--- a/udev/udev-event.c
+++ b/udev/udev-event.c
@@ -472,8 +472,6 @@ static int rename_netif(struct udev_event *event)
 
 	info(event->udev, "changing net interface name from '%s' to '%s'\n",
 	     udev_device_get_sysname(dev), event->name);
-	if (event->test)
-		return 0;
 
 	sk = socket(PF_INET, SOCK_DGRAM, 0);
 	if (sk < 0) {
@@ -584,22 +582,24 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules)
 		util_strlcat(filename, event->name, sizeof(filename));
 		udev_device_set_devnode(dev, filename);
 
-		/* read current database entry */
+		/* read old database entry */
 		dev_old = udev_device_new_from_syspath(event->udev, udev_device_get_syspath(dev));
 		if (dev_old != NULL) {
 			udev_device_read_db(dev_old);
 			udev_device_set_info_loaded(dev_old);
 		}
 
-		/* update database, create node and symlinks */
+		/* write current database entry */
 		udev_device_update_db(dev);
-		err = udev_node_add(dev, event->mode, event->uid, event->gid, event->test);
 
 		/* remove/update possible left-over symlinks from old database entry */
 		if (dev_old != NULL) {
-			udev_node_update_old_links(dev, dev_old, event->test);
+			udev_node_update_old_links(dev, dev_old);
 			udev_device_unref(dev_old);
 		}
+
+		/* create new node and symlinks */
+		err = udev_node_add(dev, event->mode, event->uid, event->gid);
 		goto exit;
 	}
 
@@ -673,7 +673,7 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules)
 			goto exit;
 		}
 
-		err = udev_node_remove(dev, event->test);
+		err = udev_node_remove(dev);
 		goto exit;
 	}