X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Ftmpfiles%2Ftmpfiles.c;h=bf900fa3d9c458460b2218dffa08e7e32940fe26;hb=2abba39d759bacebd7461f7370bb108f48dcce92;hp=ed51ec8a7f8dd8fc719045625b701f12a212e6d1;hpb=3612fbc1e4ae57af0783cc82a56917bcd29a0431;p=elogind.git diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index ed51ec8a7..bf900fa3d 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -42,6 +42,7 @@ #include "log.h" #include "util.h" +#include "macro.h" #include "mkdir.h" #include "path-util.h" #include "strv.h" @@ -503,24 +504,15 @@ static int write_one_file(Item *i, const char *path) { if (i->argument) { ssize_t n; size_t l; - struct iovec iovec[2]; - static const char new_line = '\n'; + _cleanup_free_ char *unescaped; - l = strlen(i->argument); + unescaped = cunescape(i->argument); + if (unescaped == NULL) + return log_oom(); - zero(iovec); - iovec[0].iov_base = i->argument; - iovec[0].iov_len = l; + l = strlen(unescaped); + n = write(fd, unescaped, l); - iovec[1].iov_base = (void*) &new_line; - iovec[1].iov_len = 1; - - n = writev(fd, iovec, 2); - - /* It's OK if we don't write the trailing - * newline, hence we check for l, instead of - * l+1 here. Files in /sys often refuse - * writing of the trailing newline. */ if (n < 0 || (size_t) n < l) { log_error("Failed to write file %s: %s", path, n < 0 ? strerror(-n) : "Short write"); close_nointr_nofail(fd); @@ -559,12 +551,13 @@ static int recursive_relabel_children(Item *i, const char *path) { return errno == ENOENT ? 0 : -errno; for (;;) { - struct dirent buf, *de; + struct dirent *de; + union dirent_storage buf; bool is_dir; int r; char *entry_path; - r = readdir_r(d, &buf, &de); + r = readdir_r(d, &buf.de, &de); if (r != 0) { if (ret == 0) ret = -r; @@ -680,6 +673,10 @@ static int create_item(Item *i) { case CREATE_FILE: case TRUNCATE_FILE: + r = write_one_file(i, i->path); + if (r < 0) + return r; + break; case WRITE_FILE: r = glob_item(i, write_one_file); if (r < 0)