X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fjournal%2Fjournald-stream.c;h=76580f8263a161f4c323bfc2e2b4b5d574a62cc9;hb=bf3d3e2bb7ae2d3854be57f28dd1403c8f7e4c3c;hp=c46ffe5d455e0345b55f805c49f1255a6ecf5361;hpb=40b71e89bae4e51768db4dc50ec64c1e9c96eec4;p=elogind.git diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index c46ffe5d4..76580f826 100644 --- a/src/journal/journald-stream.c +++ b/src/journal/journald-stream.c @@ -341,8 +341,7 @@ void stdout_stream_free(StdoutStream *s) { s->event_source = sd_event_source_unref(s->event_source); } - if (s->fd >= 0) - close_nointr_nofail(s->fd); + safe_close(s->fd); #ifdef HAVE_SELINUX if (s->security_context) @@ -377,13 +376,13 @@ static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revent if (s->n_stdout_streams >= STDOUT_STREAMS_MAX) { log_warning("Too many stdout streams, refusing connection."); - close_nointr_nofail(fd); + safe_close(fd); return 0; } stream = new0(StdoutStream, 1); if (!stream) { - close_nointr_nofail(fd); + safe_close(fd); return log_oom(); } @@ -396,7 +395,7 @@ static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revent } #ifdef HAVE_SELINUX - if (use_selinux()) { + if (mac_selinux_use()) { if (getpeercon(fd, &stream->security_context) < 0 && errno != ENOPROTOOPT) log_error("Failed to determine peer security context: %m"); } @@ -451,14 +450,14 @@ int server_open_stdout_socket(Server *s) { r = bind(s->stdout_fd, &sa.sa, offsetof(union sockaddr_union, un.sun_path) + strlen(sa.un.sun_path)); if (r < 0) { - log_error("bind() failed: %m"); + log_error("bind(%s) failed: %m", sa.un.sun_path); return -errno; } chmod(sa.un.sun_path, 0666); if (listen(s->stdout_fd, SOMAXCONN) < 0) { - log_error("listen() failed: %m"); + log_error("listen(%s) failed: %m", sa.un.sun_path); return -errno; } } else