X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fcore%2Fmount.c;h=a39076838b205f80fc0b2110131bfa78566adcf9;hb=a2c0e528b8b5ba370527db279605e4e4135689c1;hp=c961677ff98382a69b4f51e9a4fc7b08551124d8;hpb=befb6d54948480f836d53d633bef27e3505818c1;p=elogind.git diff --git a/src/core/mount.c b/src/core/mount.c index c961677ff..a39076838 100644 --- a/src/core/mount.c +++ b/src/core/mount.c @@ -45,6 +45,9 @@ #include "exit-status.h" #include "def.h" +DEFINE_TRIVIAL_CLEANUP_FUNC(struct libmnt_table*, mnt_free_table); +DEFINE_TRIVIAL_CLEANUP_FUNC(struct libmnt_iter*, mnt_free_iter); + static const UnitActiveState state_translation_table[_MOUNT_STATE_MAX] = { [MOUNT_DEAD] = UNIT_INACTIVE, [MOUNT_MOUNTING] = UNIT_ACTIVATING, @@ -64,19 +67,23 @@ static const UnitActiveState state_translation_table[_MOUNT_STATE_MAX] = { static int mount_dispatch_timer(sd_event_source *source, usec_t usec, void *userdata); static int mount_dispatch_io(sd_event_source *source, int fd, uint32_t revents, void *userdata); -static bool mount_is_network(MountParameters *p) { - assert(p); - - if (mount_test_option(p->options, "_netdev")) +static bool mount_needs_network(const char *options, const char *fstype) { + if (mount_test_option(options, "_netdev")) return true; - if (p->fstype && fstype_is_network(p->fstype)) + if (fstype && fstype_is_network(fstype)) return true; return false; } -static bool mount_is_bind(MountParameters *p) { +static bool mount_is_network(const MountParameters *p) { + assert(p); + + return mount_needs_network(p->options, p->fstype); +} + +static bool mount_is_bind(const MountParameters *p) { assert(p); if (mount_test_option(p->options, "bind")) @@ -94,13 +101,13 @@ static bool mount_is_bind(MountParameters *p) { return false; } -static bool mount_is_auto(MountParameters *p) { +static bool mount_is_auto(const MountParameters *p) { assert(p); return !mount_test_option(p->options, "noauto"); } -static bool needs_quota(MountParameters *p) { +static bool needs_quota(const MountParameters *p) { assert(p); if (mount_is_network(p)) @@ -1412,8 +1419,7 @@ static int mount_add_one( if (m->running_as == SYSTEMD_SYSTEM) { const char* target; - target = fstype_is_network(fstype) ? SPECIAL_REMOTE_FS_TARGET : SPECIAL_LOCAL_FS_TARGET; - + target = mount_needs_network(options, fstype) ? SPECIAL_REMOTE_FS_TARGET : SPECIAL_LOCAL_FS_TARGET; r = unit_add_dependency_by_name(u, UNIT_BEFORE, target, NULL, true); if (r < 0) goto fail; @@ -1438,6 +1444,15 @@ static int mount_add_one( } } + if (m->running_as == SYSTEMD_SYSTEM && + mount_needs_network(options, fstype)) { + /* _netdev option may have shown up late, or on a + * remount. Add remote-fs dependencies, even though + * local-fs ones may already be there. */ + unit_add_dependency_by_name(u, UNIT_BEFORE, SPECIAL_REMOTE_FS_TARGET, NULL, true); + load_extras = true; + } + if (u->load_state == UNIT_NOT_FOUND) { u->load_state = UNIT_LOADED; u->load_error = 0; @@ -1502,17 +1517,9 @@ fail: return r; } -static inline void mnt_free_table_p(struct libmnt_table **tb) { - mnt_free_table(*tb); -} - -static inline void mnt_free_iter_p(struct libmnt_iter **itr) { - mnt_free_iter(*itr); -} - static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) { - _cleanup_(mnt_free_table_p) struct libmnt_table *tb = NULL; - _cleanup_(mnt_free_iter_p) struct libmnt_iter *itr = NULL; + _cleanup_(mnt_free_tablep) struct libmnt_table *tb = NULL; + _cleanup_(mnt_free_iterp) struct libmnt_iter *itr = NULL; struct libmnt_fs *fs; int r = 0; @@ -1523,15 +1530,22 @@ static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) { if (!tb || !itr) return log_oom(); - mnt_table_parse_mtab(tb, NULL); - if (r) + r = mnt_table_parse_mtab(tb, NULL); + if (r < 0) return r; - while (mnt_table_next_fs(tb, itr, &fs) == 0) { + r = 0; + for (;;) { const char *device, *path, *options, *fstype; _cleanup_free_ const char *d = NULL, *p = NULL; int k; + k = mnt_table_next_fs(tb, itr, &fs); + if (k == 1) + break; + else if (k < 0) + return log_error_errno(k, "Failed to get next entry from /etc/fstab: %m"); + device = mnt_fs_get_source(fs); path = mnt_fs_get_target(fs); options = mnt_fs_get_options(fs); @@ -1543,7 +1557,7 @@ static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) { return log_oom(); k = mount_add_one(m, d, p, options, fstype, set_flags); - if (k < 0) + if (r == 0 && k < 0) r = k; } @@ -1605,6 +1619,8 @@ static int mount_enumerate(Manager *m) { if (m->utab_inotify_fd < 0) goto fail_with_errno; + (void) mkdir_p_label("/run/mount", 0755); + r = inotify_add_watch(m->utab_inotify_fd, "/run/mount", IN_MOVED_TO); if (r < 0) goto fail_with_errno; @@ -1641,8 +1657,8 @@ static int mount_dispatch_io(sd_event_source *source, int fd, uint32_t revents, /* The manager calls this for every fd event happening on the * /proc/self/mountinfo file, which informs us about mounting - * table changes - * This may also be called for /run/mount events */ + * table changes, and for /run/mount events which we watch + * for mount options. */ if (fd == m->utab_inotify_fd) { char inotify_buffer[sizeof(struct inotify_event) + NAME_MAX + 1]; @@ -1650,18 +1666,18 @@ static int mount_dispatch_io(sd_event_source *source, int fd, uint32_t revents, char *p; int rescan = 0; - while ((r = read(fd, inotify_buffer, sizeof(inotify_buffer))) > 0) { + while ((r = read(fd, inotify_buffer, sizeof(inotify_buffer))) > 0) for (p = inotify_buffer; p < inotify_buffer + r; ) { event = (struct inotify_event *) p; /* only care about changes to utab, but we have * to monitor the directory to reliably get * notifications about when utab is replaced * using rename(2) */ - if (strcmp(event->name, "utab") == 0) + if ((event->mask & IN_Q_OVERFLOW) || streq(event->name, "utab")) rescan = 1; p += sizeof(struct inotify_event) + event->len; } - } + if (!rescan) return 0; }