X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fcore%2Fcondition.c;h=353e0c97f1d64c50bf15f24a1076af748e1ca508;hb=671174136525ddf208cdbe75d6d6bd159afa961f;hp=1448fa19dc3eb6bc039df94828541e951d521c45;hpb=099524d7b0df690e3361ffc3fe3c6aed0558b4fc;p=elogind.git diff --git a/src/core/condition.c b/src/core/condition.c index 1448fa19d..353e0c97f 100644 --- a/src/core/condition.c +++ b/src/core/condition.c @@ -27,7 +27,7 @@ #include #include -#include +#include "sd-id128.h" #include "util.h" #include "condition.h" #include "virt.h" @@ -52,14 +52,15 @@ static bool condition_test_security(Condition *c) { return use_ima() == !c->negate; if (streq(c->parameter, "smack")) return use_smack() == !c->negate; + return c->negate; } static bool condition_test_capability(Condition *c) { + _cleanup_fclose_ FILE *f = NULL; cap_value_t value; - FILE *f; char line[LINE_MAX]; - unsigned long long capabilities = (unsigned long long) -1; + unsigned long long capabilities = -1; assert(c); assert(c->parameter); @@ -86,11 +87,53 @@ static bool condition_test_capability(Condition *c) { } } - fclose(f); - return !!(capabilities & (1ULL << value)) == !c->negate; } +static bool condition_test_needs_update(Condition *c) { + const char *p; + struct stat usr, other; + + assert(c); + assert(c->parameter); + assert(c->type == CONDITION_NEEDS_UPDATE); + + /* If the file system is read-only we shouldn't suggest an update */ + if (path_is_read_only_fs(c->parameter) > 0) + return c->negate; + + /* Any other failure means we should allow the condition to be true, + * so that we rather invoke too many update tools then too + * few. */ + + if (!path_is_absolute(c->parameter)) + return !c->negate; + + p = strappenda(c->parameter, "/.updated"); + if (lstat(p, &other) < 0) + return !c->negate; + + if (lstat("/usr/", &usr) < 0) + return !c->negate; + + return (usr.st_mtim.tv_sec > other.st_mtim.tv_sec || + (usr.st_mtim.tv_sec == other.st_mtim.tv_sec && usr.st_mtim.tv_nsec > other.st_mtim.tv_nsec)) == !c->negate; +} + +static bool condition_test_first_boot(Condition *c) { + int r; + + assert(c); + assert(c->parameter); + assert(c->type == CONDITION_FIRST_BOOT); + + r = parse_boolean(c->parameter); + if (r < 0) + return c->negate; + + return ((access("/run/systemd/first-boot", F_OK) >= 0) == !!r) == !c->negate; +} + static bool condition_test(Condition *c) { assert(c); @@ -170,6 +213,12 @@ static bool condition_test(Condition *c) { case CONDITION_ARCHITECTURE: return condition_test_architecture(c); + case CONDITION_NEEDS_UPDATE: + return condition_test_needs_update(c); + + case CONDITION_FIRST_BOOT: + return condition_test_first_boot(c); + case CONDITION_NULL: return !c->negate;