X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=git-debrebase;h=781435861ecb05b1c816a440364425746abae6f7;hb=0485d821f0e4ec4f13192e3de6747087ece3aae1;hp=e307af843da884e4d5e8b39fd9fec8f68465bc30;hpb=44250fed27c2cf4b3ff93e6510a8017fcc09c402;p=dgit.git

diff --git a/git-debrebase b/git-debrebase
index e307af84..78143586 100755
--- a/git-debrebase
+++ b/git-debrebase
@@ -3,7 +3,8 @@
 # Script helping make fast-forwarding histories while still rebasing
 # upstream deltas when working on Debian packaging
 #
-# Copyright (C)2017,2018 Ian Jackson
+# Copyright (C)2017-2019 Ian Jackson
+# Copyright (C)2019      Niko Tyni
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -120,7 +121,6 @@ our $playprefix = 'debrebase';
 our $rd;
 our $workarea;
 
-our @git = qw(git);
 our @dgit = qw(dgit);
 
 sub in_workarea ($) {
@@ -1973,7 +1973,7 @@ sub cmd_new_upstream () {
 	$new_version = (new Dpkg::Version "$spec_version-1", check => 1);
     }
 
-    my $new_upstream = shift @ARGV;
+    my $new_upstream = (@ARGV && $ARGV[0] !~ m{^-}) ? shift @ARGV : undef;
     my $new_upstream_version = upstreamversion  $new_version;
     my $new_upstream_used;
     ($new_upstream, $new_upstream_used) =
@@ -2662,7 +2662,7 @@ sub cmd_convert_from_dgit_view () {
 	my $spec = shift @ARGV;
 	my $commit = git_rev_parse "$spec^{commit}";
 	push @upstreams, { Commit => $commit,
-			   Source => (f_ "%s, from command line", $ARGV[0]),
+			   Source => (f_ "%s, from command line", $spec),
 			   Only => 1,
 			 };
     }
@@ -2697,10 +2697,11 @@ END
     if (!@upstreams) {
 	if ($do_tags) {
 	    my @tried;
-	    my $ups_tag = upstream_commitish_search $version, \@tried;
-	    if ($ups_tag) {
-		my $this = f_ "git tag %s", $tried[-1];
-		push @upstreams, { Commit => $ups_tag,
+	    my ($ups_tag, $ups_rev) =
+	        upstream_commitish_search $version, \@tried;
+	    if ($ups_rev) {
+		my $this = f_ "git tag %s", $ups_tag;
+		push @upstreams, { Commit => $ups_rev,
 				   Source => $this,
 				 };
 	    } else {
@@ -2949,7 +2950,7 @@ getoptions_main
 	   'experimental-merge-resolution!', \$opt_merges,
 	   '-i:s' => sub {
 	       my ($opt,$val) = @_;
-	       badusage f_ "%s: no cuddling to -i for git-rebase", $us
+	       badusage f_ "%s: with git-debrebase, get-rebase -i option may only be followed by more options (as separate arguments)", $us
 		   if length $val;
 	       confess if $opt_defaultcmd_interactive; # should not happen
 	       $opt_defaultcmd_interactive = [ qw(-i) ];