X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=git-debrebase;h=3cab3ad8837b4a28a4bc51be3bcad29d123ebd20;hb=8b38c204c268e0e862036c273a6298ccc9ea46fd;hp=fbf2a58a7188b49203ee78197b0ad406b1ced34a;hpb=e5fa171de2df26246f6bc1efeb6b101d1588d700;p=dgit.git diff --git a/git-debrebase b/git-debrebase index fbf2a58a..3cab3ad8 100755 --- a/git-debrebase +++ b/git-debrebase @@ -238,8 +238,8 @@ sub make_commit ($$) { } our @snag_force_opts; -sub snag ($$) { - my ($tag,$msg) = @_; +sub snag ($$;@) { + my ($tag,$msg) = @_; # ignores extra args, for benefit of keycommits if (grep { $_ eq $tag } @snag_force_opts) { $snags_forced++; print STDERR "git-debrebase: snag ignored (-f$tag): $msg\n"; @@ -538,13 +538,13 @@ sub classify ($) { return $unknown->("complex merge"); } -sub keycommits ($;$$$) { - my ($head, $furniture, $unclean, $trouble) = @_; +sub keycommits ($;$$$$) { + my ($head, $furniture, $unclean, $trouble, $fatal) = @_; # => ($anchor, $breakwater) - # $unclean->("unclean-$tagsfx", $msg) - # $furniture->("unclean-$tagsfx", $msg) - # $dgitimport->("unclean-$tagsfx", $msg) + # $unclean->("unclean-$tagsfx", $msg, $cl) + # $furniture->("unclean-$tagsfx", $msg, $cl) + # $dgitimport->("unclean-$tagsfx", $msg, $cl)) # is callled for each situation or commit that # wouldn't be found in a laundered branch # $furniture is for furniture commits such as might be found on an @@ -552,6 +552,8 @@ sub keycommits ($;$$$) { # $trouble is for things whnich prevent the return of # anchor and breakwater information; if that is ignored, # then keycommits returns (undef, undef) instead. + # $fatal is for unprocessable commits, and should normally cause + # a failure. If ignored, agaion, (undef, undef) is returned. # # If a callback is undef, fail is called instead. # If a callback is defined but false, the situation is ignored. @@ -561,15 +563,17 @@ sub keycommits ($;$$$) { my ($anchor, $breakwater); my $clogonly; + my $cl; + $fatal //= sub { fail $_[2]; }; my $x = sub { my ($cb, $tagsfx, $why) = @_; my $m = "branch needs laundering (run git-debrebase): $why"; fail $m unless defined $cb; return unless $cb; - $cb->("unclean-$tagsfx", $why); + $cb->("unclean-$tagsfx", $why, $cl); }; for (;;) { - my $cl = classify $head; + $cl = classify $head; my $ty = $cl->{Type}; if ($ty eq 'Packaging') { $breakwater //= $clogonly; @@ -603,12 +607,12 @@ sub keycommits ($;$$$) { } elsif ($ty eq 'DgitImportUnpatched') { $x->($trouble, 'dgitimport', "found dgit dsc import ($head)"); - $breakwater = undef; - $anchor = undef; - no warnings qw(exiting); - last; + return (undef,undef); } else { - fail "found unprocessable commit, cannot cope: $head; $cl->{Why}"; + $x->($fatal, 'unprocessable', + "found unprocessable commit, cannot cope: $head; $cl->{Why}" + ); + return (undef,undef); } $head = $cl->{Parents}[0]{CommitId}; } @@ -1365,6 +1369,83 @@ sub cmd_breakwater () { print "$bw\n" or die $!; } +sub cmd_status () { + badusage "no arguments allowed" if @ARGV; + + my $oldest = [ 0 ]; + my $newest; + my $note = sub { + my ($badness, $ourmsg, $snagname, $kcmsg, $cl) = @_; + if ($oldest->[0] < $badness) { + $oldest = $newest = undef; + } + $oldest = \@_; # we're walking backwards + $newest //= \@_; + }; + my ($anchor, $bw) = keycommits +(git_rev_parse 'HEAD'), + sub { $note->(1, 'branch contains furniture (not laundered)', @_); }, + sub { $note->(2, 'branch is unlaundered', @_); }, + sub { $note->(3, 'branch needs laundering', @_); }, + sub { $note->(4, 'branch not in git-debrebase form', @_); }; + + my $prcommitinfo = sub { + my ($cid) = @_; + flush STDOUT or die $!; + runcmd @git, qw(--no-pager log -n1), + '--pretty=format: %h %s%n', + $cid; + }; + + print "current branch contents, in git-debrebase terms:\n"; + if (!$oldest->[0]) { + print " branch is laundered\n"; + } else { + print " $oldest->[1]\n"; + my $printed = ''; + foreach my $info ($oldest, $newest) { + my $cid = $info->[4]{CommitId}; + next if $cid eq $printed; + $printed = $cid; + print " $info->[3]\n"; + $prcommitinfo->($cid); + } + } + + my $prab = sub { + my ($cid, $what) = @_; + if (!defined $cid) { + print " $what is not well-defined\n"; + } else { + print " $what\n"; + $prcommitinfo->($cid); + } + }; + print "key git-debrebase commits:\n"; + $prab->($anchor, 'anchor'); + $prab->($bw, 'breakwater'); + + my ($ffqstatus, $ffq_msg, $current, $ffq_prev, $gdrlast) = + ffq_prev_branchinfo(); + + print "branch and ref status, in git-debrebase terms:\n"; + if ($ffq_msg) { + print " $ffq_msg\n"; + } else { + $ffq_prev = git_get_ref $ffq_prev; + $gdrlast = git_get_ref $gdrlast; + if ($ffq_prev) { + print " unstitched; previous tip was:\n"; + $prcommitinfo->($ffq_prev); + } elsif (!$gdrlast) { + print " stitched? (no record of git-debrebase work)\n"; + } elsif (is_fast_fwd $gdrlast, 'HEAD') { + print " stitched\n"; + } else { + print " not git-debrebase (diverged since last stitch)\n" + } + } +} + sub cmd_stitch () { my $prose = 'stitch'; GetOptions('prose=s', \$prose) or die badusage("bad options to stitch"); @@ -1420,28 +1501,25 @@ sub make_patches ($) { '[git-debrebase: export and commit patches]', ]; }; - my $d = get_differs $head, $out; - if ($d == 0) { - return undef; # nothing to do - } elsif ($d == D_PAT_ADD) { - return $out; # OK - } else { - fail "Patch export produced patch amendments". - " (abandoned output commit $out).". - " Try laundering first."; - } + return $out; } sub cmd_make_patches () { badusage "no arguments allowed" if @ARGV; my $old_head = get_head(); my $new = make_patches $old_head; - snags_maybe_bail(); - if (!$new) { + my $d = get_differs $old_head, $new; + if ($d == 0) { fail "No (more) patches to export." unless $opt_noop_ok; return; + } elsif ($d == D_PAT_ADD) { + snags_maybe_bail(); + update_head_checkout $old_head, $new, 'make-patches'; + } else { + fail "Patch export produced patch amendments". + " (abandoned output commit $new).". + " Try laundering first."; } - update_head_checkout $old_head, $new, 'make-patches'; } sub cmd_convert_from_gbp () {