X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=git-debrebase;h=1b77b084fe6760cf5acd3c527cf7ce1106f197b4;hb=3a138686f34b4f85f31e5c339d544d12e6479a32;hp=b306d60d576ffb3feffba894c769009a6297d557;hpb=77eadb96882721c03d9b517a28a6468f2fa362a8;p=dgit.git
diff --git a/git-debrebase b/git-debrebase
index b306d60d..1b77b084 100755
--- a/git-debrebase
+++ b/git-debrebase
@@ -19,30 +19,93 @@
# along with this program. If not, see .
# usages:
-# git-debrebase launder # prints breakwater tip
-# git-debrebase analyse
-# git-debrebase start # like ffrebase start + debrebase launder
-# git-debrebase new-upstream [-f] UPSTREAM
+# git-debrebase status
+# git-debrebase start # like ffqrebase start + debrebase launder
+# git-debrebase new-upstream [stuff] # see below
# git-debrebase # does debrebase start if necessary
#
+# git-debrebase analyse
+# git-debrebase launder # prints breakwater tip
+# git-debrebase create-new-upstream-breakwater [-f] ...
+#
+# is
+# [,][:][+][,...]
+#
+# if initial comma is supplied, entries are not positional. Unspecified
+# means root (and there may be only one).
+# xxx want auto branch names
+# xxx too complicated
+# how about for now
+# [+] [ [+]...]
+# ? plus options
+# --new-upstream-different-subtrees
+#
+# automatic case
+# git-debrebase new-upstream
+# - previous breakwater merge must be gdr-generated
+# - orig set is the same as before
+# - implicitly uses upstream branches according to orig set
+# - not all upstream branches need be updated
+# - insists on fast-forward of each branch, unless
+# --force (or --force=[/])
+# branch set adjustments
+# git-debrebase new-upstream --add /
+# git-debrebase new-upstream --rm /
+# git-debrebase new-upstream / [/ ...]
+# - orig set is adjusted
+# - otherwise like auto (--add is not checked for ffness, obv)
+# - multiple --add and --rm may be specified
+# - --add makes new upstream the last contributor
+# explicit
+# git-debrebase / [] [/ [] ...]
+# - orig set is precisely as specified now
+# - previous breakwater merge is irrelevant
+# - no fast forward checks
+# for now only explicit with commitids
+
+# implicitly uses `upstream'
+# # (or multiple other branches)
+# git-debrebase new-upstream \
+# [/]=
+
+# UPSTREAM[,[[SUBDIR:]SUBUPSTREAM]
+# default for SUBDIR: is from previous upstream merge[xxx terminology]
+#
+#
#xxx
# when starting must record original start (for ff)
# and new rebase basis
#
-# git-ffrebase start [BASE] # records previous HEAD so it can be overwritten
-# # records base for future git-ffrebase
-# git-ffrebase set-base BASE
-# git-ffrebase
-# git-ffrebase finish
-# git-ffrebase status [BRANCH]
+# git-ffqrebase start [BASE]
+# # records previous HEAD so it can be overwritten
+# # records base for future git-ffqrebase
+# git-ffqrebase set-base BASE
+# git-ffqrebase
+# git-ffqrebase finish
+# git-ffqrebase status [BRANCH]
#
-# refs/ffrebase-prev/BRANCH BRANCH may be refs/...; if not it means
-# refs/ffrebase-base/BRANCH refs/heads/BRANCH
+# refs/ffqrebase-prev/BRANCH BRANCH may be refs/...; if not it means
+# refs/ffqrebase-base/BRANCH refs/heads/BRANCH
# zero, one, or both of these may exist
+#
+# git-debrebase without start, if already started, is willing
+# to strip pseudomerges provided that they overwrite exactly
+# the previous HEAD
+# xxxx is this right ? what matters is have we pushed
+# I think in fact the right answer is:
+# git-debrebase always strips out pseudomerges from its branch
+# a pseudomerge is put in at the time we want to push
+# at that time, we make a pseudomerge of the remote tracking
+# branch (if raw git) or the dgit view (if dgit)
+# for raw git git-ffqrebase, do want preciseley to record
+# value of remote tracking branch or our branch, on start, so we
+# overwrite only things we intend to
+# the previous pseudomerge check for tags and remote branches ?
use strict;
use Memoize;
+use Carp;
use Data::Dumper;
use Debian::Dgit qw(:DEFAULT $wa);
@@ -67,13 +130,14 @@ sub get_commit ($) {
return ($`,$');
}
-sub D_DEB () { return 0x1; }
-sub D_UPS () { return 0x2; }
-sub D_PAT_ADD () { return 0x4; }
-sub D_PAT_OTH () { return 0x8; }
+sub D_DEB () { return 0x1; } # debian/ (not including debian/patches/)
+sub D_UPS () { return 0x2; } # upstream files
+sub D_PAT_ADD () { return 0x4; } # debian/patches/ extra patches at end
+sub D_PAT_OTH () { return 0x8; } # debian/patches other changes
our $rd = ".git/git-debrebase";
our $ud = "$rd/work";
+our @git = qw(git);
sub commit_pr_info ($) {
my ($r) = @_;
@@ -82,24 +146,60 @@ sub commit_pr_info ($) {
sub calculate_committer_authline () {
my $c = cmdoutput @git, qw(commit-tree --no-gpg-sign -m),
- 'XXX DUMMY COMMIT (git-debrebase)', "$basis:";
+ 'DUMMY COMMIT (git-debrebase)', "HEAD:";
my ($h,$m) = get_commit $c;
$h =~ m/^committer .*$/m or confess "($h) ?";
return $&;
}
+# classify returns an info hash like this
+# CommitId => $objid
+# Hdr => # commit headers, including 1 final newline
+# Msg => # commit message (so one newline is dropped)
+# Tree => $treeobjid
+# Type => (see below)
+# Parents = [ {
+# Ix => $index # ie 0, 1, 2, ...
+# CommitId
+# Differs => return value from get_differs
+# IsOrigin
+# IsDggitImport => 'orig' 'tarball' 'unpatched' 'package' (as from dgit)
+# } ...]
+# NewMsg => # commit message, but with any [dgit import ...] edited
+# # to say "[was: ...]"
+#
+# Types:
+# Packaging
+# Upstream
+# AddPatches
+# Mixed
+# Unknown
+#
+# Pseudomerge
+# has additional entres in classification result
+# Overwritten = [ subset of Parents ]
+# Contributor = $the_remaining_Parent
+#
+# DgitImportUnpatched
+# has additional entry in classification result
+# OrigParents = [ subset of Parents ]
+#
+# BreakwaterUpstreamMerge
+# has additional entry in classification result
+# OrigParents = [ subset of Parents ]
+
sub classify ($) {
my ($objid) = @_;
my ($h,$m) = get_commit $objid;
- my ($t) = $h =~ m/^tree (\w+)$/m or die $cur;
+ my ($t) = $h =~ m/^tree (\w+)$/m or die $objid;
my (@ph) = $h =~ m/^parent (\w+)$/m;
my @p;
my $r = {
CommitId => $objid,
- Hdr => $hdr,
+ Hdr => $h,
Msg => $m,
Tree => $t,
Parents => \@p,
@@ -115,26 +215,26 @@ sub classify ($) {
my $classify = sub {
my ($type, @rest) = @_;
- $r = { %r, Type => $type, @rest };
+ $r = { %$r, Type => $type, @rest };
return $r;
};
my $unknown = sub {
my ($why) = @_;
- $r = { %r, Type => Unknown };
+ $r = { %$r, Type => qw(Unknown) };
return $r;
- }
+ };
if (@p == 1) {
my $d = $r->{Parents}[0]{Differs};
- if ($d == D_DPAT_ADD) {
+ if ($d == D_PAT_ADD) {
return $classify->(qw(AddPatches));
- } elsif ($d & (D_DPAT_ADD|D_DPAT_OTH)) {
+ } elsif ($d & (D_PAT_ADD|D_PAT_OTH)) {
return $unknown->("edits debian/patches");
} elsif ($d == D_DEB) {
return $classify->(qw(Packaging));
} elsif ($d == D_UPS) {
return $classify->(qw(Upstream));
- } elsif ($d == D_DEB|D_UPS) {
+ } elsif ($d == (D_DEB|D_UPS)) {
return $classify->(qw(Mixed));
} elsif ($d == 0) {
return $unknown->("no changes");
@@ -164,16 +264,16 @@ sub classify ($) {
SubType => qw(Ambiguous),
Overwritten => $bytime[0],
Contributor => $bytime[1]);
- }!
+ }
foreach my $p (@p) {
my ($p_h, $p_m) = get_commit $p;
$p->{IsOrigin} = $p_h !~ m/^parent \w+$/m;
($p->{IsDgitImport},) = $p_m =~ m/^\[dgit import ([0-9a-z]+) .*\]$/m;
}
- my @orig_ps = grep { ($_->{IsDgitImport}//'X') eq 'orig' };
+ my @orig_ps = grep { ($_->{IsDgitImport}//'X') eq 'orig' } @p;
my $m2 = $m;
if (!(grep { !$_->{IsOrigin} } @p) and
- (@origs >= @p - 1) and
+ (@orig_ps >= @p - 1) and
$m2 =~ s{^\[(dgit import unpatched .*)\]$}{[was: $1]}m) {
$r->{NewMsg} = $m2;
return $classify->(qw(DgitImportUnpatched),
@@ -195,20 +295,27 @@ sub classify ($) {
!($p[0]{Differs} & ~D_DEB) &&
!($p[1]{Differs} & ~D_UPS)) {
return $classify->(qw(BreakwaterUpstreamMerge),
- Upstream => $p[1]);
+ OrigParents => [ $p[1] ]);
}
+ # xxx multi-.orig upstreams
return $unknown->("complex merge");
}
-sub launder ($$$) {
- my ($input, $pseudos_must_overwrite_this, $wantdebonly) = @_;
+sub walk ($;$$$$);
+sub walk {
+ my ($input,
+ $nogenerate,$report,
+ $wantdebonly,$depth) = @_;
# go through commits backwards
# we generate two lists of commits to apply
- my (@deb_cl, @ups_cl);
+ # => ($tip, $breakwater_tip)
+ my (@deb_cl, @ups_cl, @processed);
my %found;
my @pseudomerges;
+ $depth //= 0;
+
my $cl;
my $xmsg = sub {
my ($appendinfo) = @_;
@@ -217,17 +324,30 @@ sub launder ($$$) {
$ms .= "\n\n[git-debrebase $appendinfo]\n";
return (Msg => $ms);
};
+ my $rewrite_from_here = sub {
+ push @processed, { SpecialMethod => 'StartRewrite' };
+ };
my $cur = $input;
+ my $basis;
+
+ my $prdelim = "";
+ my $prprdelim = sub { print $report $prdelim if $report; $prdelim=""; };
for (;;) {
$cl = classify $cur;
my $ty = $cl->{Type};
my $st = $cl->{SubType};
+ if ($report) {
+ print $report $prdelim, "$cl->{CommitId} $cl->{Type}";
+ $prdelim = "\n";
+ }
$found{$ty. ( defined($st) ? "-$st" : '' )}++;
+ push @processed, $cl;
my $p0 = $cl->{Parents}[0]{CommitId};
if ($ty eq 'AddPatches') {
$cur = $p0;
+ $rewrite_from_here->();
next;
} elsif ($ty eq 'Packaging') {
push @deb_cl, $cl;
@@ -245,12 +365,12 @@ sub launder ($$$) {
};
$queue->(\@deb_cl, "debian");
$queue->(\@ups_cl, "upstream");
+ $rewrite_from_here->();
next;
} elsif ($ty eq 'Pseudomerge') {
- if (defined $pseudos_must_overwrite_this) {
- confess 'xxx actually check this';
- }
+ print $report " Contributor=$ty->{Contributor}" if $report;
push @pseudomerges, $cl;
+ $rewrite_from_here->();
$cur = $ty->{Contributor};
next;
} elsif ($ty eq 'BreakwaterUpstreamMerge') {
@@ -268,7 +388,10 @@ sub launder ($$$) {
# precisely right. Otherwise, it was a non-gitish upload
# of a new upstream version. We can tell these apart
# by looking at the tree of the supposed upstream.
+ my $differs = get_differs $previous_breakwater, $cl->{Tree};
+ printf $report " Differs=%#x", $differs if $report;
if ($differs & D_UPS) {
+ printf $report " D_UPS" if $report;
push @deb_cl, {
%r,
SpecialMethod => 'DgitImportUpstreamUpdate',
@@ -280,17 +403,32 @@ sub launder ($$$) {
SpecialMethod => 'DgitImportDebianUpdate',
$xmsg->("convert dgit import: upstream changes")
};
- my $differs = get_differs $previous_breakwater, $cl->{Tree};
- $basis = launder $pseudomerges[0]{Overwritten}, undef, 1;
+ $prprdelim->();
+ $basis = walk
+ $pseudomerges[0]{Overwritten},
+ $nogenerate, $report,
+ 1, $depth+1;
+ $rewrite_from_here->();
last;
} else {
- die "Reached difficult commit $cur: ".Dumper($cl);
+ print $report " Unprocessable" if $report;
+ $prprdelim->();
+ if ($nogenerate) {
+ return (undef,undef);
+ }
+ die "commit $cur: Cannot cope with this commit";
}
}
+ $prprdelim->();
+ if ($nogenerate) {
+ return (undef, $basis);
+ }
+
# Now we build it back up again
workarea_fresh();
- in_workarea sub { xxx attributes xxx };
+
+ my $rewriting = 0;
my $build = $basis;
@@ -313,9 +451,10 @@ sub launder ($$$) {
in_workarea sub {
mkdir $rd or $!==EEXIST or die $!;
-
my $current_method;
- foreach my $cl (qw(Debian), @deb_cl, qw(Upstream), @ups_cl) {
+ foreach my $cl (qw(Debian), (reverse @deb_cl),
+ { SpecialMethod => 'RecordBreakwaterTip' },
+ qw(Upstream), (reverse @ups_cl)) {
if (!ref $cl) {
$current_method = $cl;
next;
@@ -327,6 +466,13 @@ sub launder ($$$) {
$read_tree_debian->($cltree);
} elsif ($method eq 'Upstream') {
$read_tree_upstream->($cltree);
+ } elsif ($method eq 'StartRewrite') {
+ $rewriting = 1;
+ next;
+ } elsif ($method eq 'RecordBreakwaterTip') {
+ last if $wantdebonly;
+ $breakwater = $build;
+ next;
} elsif ($method eq 'DgitImportDebianUpdate') {
$read_tree_debian->($cltree);
$rm_tree_cached(qw(debian/patches));
@@ -336,14 +482,27 @@ sub launder ($$$) {
} else {
confess "$method ?";
}
+ $rewriting ||= $cl ne pop @processed;
my $newtree = cmdoutput @git, qw(write-tree);
- my $ch = $cl->{Msg};
+ my $ch = $cl->{Hdr};
$ch =~ s{^tree .*}{tree $newtree}m or confess "$ch ?";
- $ch =~ s{^committer .*$}{$committer_authline}m or confess "$ch ?";
- open CD, ">", "$rd/m" or die $!;
+ $ch =~ s{^parent .*\n}{}m;
+ $ch =~ s{(?=^author}{
+ map { "parent $_\n" } @parents
+ }me or confess "$ch ?";
+ if ($rewrite) {
+ $ch =~ s{^committer .*$}{$committer_authline}m
+ or confess "$ch ?";
+ }
+ my $cf = "$rd/m$rewrite"
+ open CD, ">", $cf or die $!;
print CD $ch, "\n", $cl->{Msg}; or die $!;
close CD or die $!;
- my $newcommit = cmdoutput @git, qw(hash-object -t commit), "$rd/m";
+ my @cmd = (@git, qw(hash-object));
+ push @cmd, qw(-w) if $rewrite;
+ push @cmd, qw(-t commit), $cf;
+ my $newcommit = cmdoutput @cmd;
+ confess "$ch ?" unless $rewrite or $newcommit eq $cl->{CommitId};
$build = $newcommit;
}
};
@@ -352,7 +511,7 @@ sub launder ($$$) {
map { $wantdebonly ? "$_:debian" : $_ },
$input, $build;
- return $build;
+ return ($build, $breakwater);
}
sub get_head () { return git_rev_parse qw(HEAD); }
@@ -363,9 +522,27 @@ sub update_head ($$) {
}
sub cmd_launder () {
+ badusage "no arguments to launder allowed";
my $old = get_head();
- my $got = launder $old, 0, undef, 0;
- update_head $old, $new, 'launder'; # no tree changes!
+ my ($tip,$breakwater) = walk $old;
+ update_head $old, $tip, 'launder';
+ # no tree changes except debian/patches
+ runcmd @git, qw(rm --quiet -rf debian/patches);
+ printf "# breakwater tip\n%s\n", $breakwater;
+}
+
+sub cmd_analyse () {
+ die if ($ARGV[0]//'') =~ m/^-/;
+ badusage "too many arguments to analyse" if @ARGV>1;
+ my ($old) = @ARGV;
+ if (defined $old) {
+ $old = git_rev_parse $old;
+ } else {
+ $old = get_head();
+ }
+ my ($dummy,$breakwater) = walk $old, 1,*STDOUT;
+ print "$breakwater BREAKWATER\n";
+ STDOUT->error and die $!;
}
my $toplevel = runcmd @git, qw(rev-parse --show-toplevel);