timedatectl: add 'show' command to display machine-readable output

[elogind.git] / src / shared / bus-util.c

diff --git a/src/shared/bus-util.c b/src/shared/bus-util.c
index 195b1a69ea03b61eccbfec159f375dbf650bdc47..d2768d62bb61bc7da7fb806afdf96f5de50be26e 100644 (file)
--- a/src/shared/bus-util.c
+++ b/src/shared/bus-util.c
@@ -700,7 +700,8 @@ int bus_print_property(const char *name, sd_bus_message *m, bool value, bool all
                 /* Yes, heuristics! But we can change this check
                  * should it turn out to not be sufficient */
 
-                if (endswith(name, "Timestamp") || STR_IN_SET(name, "NextElapseUSecRealtime", "LastTriggerUSec")) {
+                if (endswith(name, "Timestamp") ||
+                    STR_IN_SET(name, "NextElapseUSecRealtime", "LastTriggerUSec", "TimeUSec", "RTCTimeUSec")) {
                         char timestamp[FORMAT_TIMESTAMP_MAX];
                         const char *t;
 
@@ -1094,9 +1095,9 @@ static int map_basic(sd_bus *bus, const char *member, sd_bus_message *m, unsigne
                         return r;
 
                 if (flags & BUS_MAP_BOOLEAN_AS_BOOL)
-                        * (bool*) userdata = !!b;
+                        *(bool*) userdata = b;
                 else
-                        * (int*) userdata = b;
+                        *(int*) userdata = b;
 
                 return 0;
         }
@@ -1413,7 +1414,7 @@ int bus_property_set_bool(
         if (r < 0)
                 return r;
 
-        *(bool *) userdata = !!b;
+        *(bool*) userdata = b;
         return 0;
 }
 
@@ -1747,19 +1748,34 @@ int bus_open_system_watch_bind_with_description(sd_bus **ret, const char *descri
 }
 
 struct request_name_data {
+        unsigned n_ref;
+
         const char *name;
         uint64_t flags;
         void *userdata;
 };
 
+static void request_name_destroy_callback(void *userdata) {
+        struct request_name_data *data = userdata;
+
+        assert(data);
+        assert(data->n_ref > 0);
+
+        log_info("%s n_ref=%u", __func__, data->n_ref);
+
+        data->n_ref--;
+        if (data->n_ref == 0)
+                free(data);
+}
+
 static int reload_dbus_handler(sd_bus_message *m, void *userdata, sd_bus_error *ret_error) {
-        _cleanup_free_ struct request_name_data *data = userdata;
+        struct request_name_data *data = userdata;
         const sd_bus_error *e;
         int r;
 
-        assert(m);
         assert(data);
         assert(data->name);
+        assert(data->n_ref > 0);
 
         e = sd_bus_message_get_error(m);
         if (e) {
@@ -1776,15 +1792,16 @@ static int reload_dbus_handler(sd_bus_message *m, void *userdata, sd_bus_error *
 }
 
 static int request_name_handler_may_reload_dbus(sd_bus_message *m, void *userdata, sd_bus_error *ret_error) {
-        _cleanup_free_ struct request_name_data *data = userdata;
+        struct request_name_data *data = userdata;
         uint32_t ret;
         int r;
 
         assert(m);
-        assert(userdata);
+        assert(data);
 
         if (sd_bus_message_is_method_error(m, NULL)) {
                 const sd_bus_error *e = sd_bus_message_get_error(m);
+                _cleanup_(sd_bus_slot_unrefp) sd_bus_slot *slot = NULL;
 
                 if (!sd_bus_error_has_name(e, SD_BUS_ERROR_ACCESS_DENIED)) {
                         log_debug_errno(sd_bus_error_get_errno(e),
@@ -1796,31 +1813,37 @@ static int request_name_handler_may_reload_dbus(sd_bus_message *m, void *userdat
                 }
 
                 log_debug_errno(sd_bus_error_get_errno(e),
-                                "Unable to request name, retry after reloading DBus configuration: %s",
+                                "Unable to request name, will retry after reloading DBus configuration: %s",
                                 e->message);
 
                 /* If systemd-timesyncd.service enables DynamicUser= and dbus.service
                  * started before the dynamic user is realized, then the DBus policy
                  * about timesyncd has not been enabled yet. So, let's try to reload
-                 * DBus configuration, and after that request name again. Note that it
+                 * DBus configuration, and after that request the name again. Note that it
                  * seems that no privileges are necessary to call the following method. */
 
                 r = sd_bus_call_method_async(
                                 sd_bus_message_get_bus(m),
-                                NULL,
+                                &slot,
                                 "org.freedesktop.DBus",
                                 "/org/freedesktop/DBus",
                                 "org.freedesktop.DBus",
                                 "ReloadConfig",
                                 reload_dbus_handler,
-                                userdata, NULL);
+                                data, NULL);
                 if (r < 0) {
                         log_error_errno(r, "Failed to reload DBus configuration: %m");
                         bus_enter_closing(sd_bus_message_get_bus(m));
                         return 1;
                 }
 
-                data = NULL; /* Avoid free() */
+                data->n_ref ++;
+                assert_se(sd_bus_slot_set_destroy_callback(slot, request_name_destroy_callback) >= 0);
+
+                r = sd_bus_slot_set_floating(slot, true);
+                if (r < 0)
+                        return r;
+
                 return 1;
         }
 
@@ -1854,17 +1877,37 @@ static int request_name_handler_may_reload_dbus(sd_bus_message *m, void *userdat
 }
 
 int bus_request_name_async_may_reload_dbus(sd_bus *bus, sd_bus_slot **ret_slot, const char *name, uint64_t flags, void *userdata) {
-        struct request_name_data *data;
+        _cleanup_free_ struct request_name_data *data = NULL;
+        _cleanup_(sd_bus_slot_unrefp) sd_bus_slot *slot = NULL;
+        int r;
 
-        data = new0(struct request_name_data, 1);
+        data = new(struct request_name_data, 1);
         if (!data)
                 return -ENOMEM;
 
-        data->name = name;
-        data->flags = flags;
-        data->userdata = userdata;
+        *data = (struct request_name_data) {
+                .n_ref = 1,
+                .name = name,
+                .flags = flags,
+                .userdata = userdata,
+        };
+
+        r = sd_bus_request_name_async(bus, &slot, name, flags, request_name_handler_may_reload_dbus, data);
+        if (r < 0)
+                return r;
+
+        assert_se(sd_bus_slot_set_destroy_callback(slot, request_name_destroy_callback) >= 0);
+        TAKE_PTR(data);
 
-        return sd_bus_request_name_async(bus, ret_slot, name, flags, request_name_handler_may_reload_dbus, data);
+        if (ret_slot)
+                *ret_slot = TAKE_PTR(slot);
+        else {
+                r = sd_bus_slot_set_floating(slot, true);
+                if (r < 0)
+                        return r;
+        }
+
+        return 0;
 }
 
 int bus_reply_pair_array(sd_bus_message *m, char **l) {