switch (rr->unparseable ? _DNS_TYPE_INVALID : rr->key->type) {
+ case DNS_TYPE_SRV:
+ r = dns_packet_append_uint16(p, rr->srv.priority, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_append_uint16(p, rr->srv.weight, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_append_uint16(p, rr->srv.port, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_append_name(p, rr->srv.name, NULL);
+ break;
+
case DNS_TYPE_PTR:
case DNS_TYPE_NS:
case DNS_TYPE_CNAME:
+ case DNS_TYPE_DNAME:
r = dns_packet_append_name(p, rr->ptr.name, NULL);
break;
goto fail;
}
+ r = 0;
break;
}
if (r < 0)
goto fail;
- r = dns_packet_append_uint16(p, rr->loc.latitude, NULL);
+ r = dns_packet_append_uint32(p, rr->loc.latitude, NULL);
if (r < 0)
goto fail;
- r = dns_packet_append_uint16(p, rr->loc.longitude, NULL);
+ r = dns_packet_append_uint32(p, rr->loc.longitude, NULL);
if (r < 0)
goto fail;
- r = dns_packet_append_uint16(p, rr->loc.altitude, NULL);
+ r = dns_packet_append_uint32(p, rr->loc.altitude, NULL);
break;
- case DNS_TYPE_SRV:
- case DNS_TYPE_DNAME:
case DNS_TYPE_SSHFP:
+ r = dns_packet_append_uint8(p, rr->sshfp.algorithm, NULL);
+ if (r < 0)
+ goto fail;
+ r = dns_packet_append_uint8(p, rr->sshfp.fptype, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_append_blob(p, rr->sshfp.key, rr->sshfp.key_size, NULL);
+ break;
+
case _DNS_TYPE_INVALID: /* unparseable */
default:
else
first = false;
- memcpy(ret + n, t, c);
+ memcpy(ret + n, t, r);
n += r;
continue;
} else if ((c & 0xc0) == 0xc0) {
return r;
}
+static bool loc_size_ok(uint8_t size) {
+ uint8_t m = size >> 4, e = size & 0xF;
+
+ return m <= 9 && e <= 9 && (m > 0 || e == 0);
+}
+
int dns_packet_read_rr(DnsPacket *p, DnsResourceRecord **ret, size_t *start) {
_cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
_cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
switch (rr->key->type) {
+ case DNS_TYPE_SRV:
+ r = dns_packet_read_uint16(p, &rr->srv.priority, NULL);
+ if (r < 0)
+ goto fail;
+ r = dns_packet_read_uint16(p, &rr->srv.weight, NULL);
+ if (r < 0)
+ goto fail;
+ r = dns_packet_read_uint16(p, &rr->srv.port, NULL);
+ if (r < 0)
+ goto fail;
+ r = dns_packet_read_name(p, &rr->srv.name, NULL);
+ break;
+
case DNS_TYPE_PTR:
case DNS_TYPE_NS:
case DNS_TYPE_CNAME:
+ case DNS_TYPE_DNAME:
r = dns_packet_read_name(p, &rr->ptr.name, NULL);
break;
r = strv_consume(&rr->txt.strings, s);
if (r < 0)
goto fail;
- };
+ }
+
+ r = 0;
break;
}
if (r < 0)
goto fail;
+ if (!loc_size_ok(rr->loc.size)) {
+ r = -EBADMSG;
+ goto fail;
+ }
+
r = dns_packet_read_uint8(p, &rr->loc.horiz_pre, NULL);
if (r < 0)
goto fail;
+ if (!loc_size_ok(rr->loc.horiz_pre)) {
+ r = -EBADMSG;
+ goto fail;
+ }
+
r = dns_packet_read_uint8(p, &rr->loc.vert_pre, NULL);
if (r < 0)
goto fail;
+ if (!loc_size_ok(rr->loc.vert_pre)) {
+ r = -EBADMSG;
+ goto fail;
+ }
+
r = dns_packet_read_uint32(p, &rr->loc.latitude, NULL);
if (r < 0)
goto fail;
} else {
dns_packet_rewind(p, pos);
rr->unparseable = true;
- /* fall through */
+ goto unparseable;
}
}
- case DNS_TYPE_SRV:
- case DNS_TYPE_DNAME:
case DNS_TYPE_SSHFP:
+
+ r = dns_packet_read_uint8(p, &rr->sshfp.algorithm, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_read_uint8(p, &rr->sshfp.fptype, NULL);
+ if (r < 0)
+ goto fail;
+
+ r = dns_packet_read(p, rdlength - 2, &d, NULL);
+ if (r < 0)
+ goto fail;
+
+ rr->sshfp.key = memdup(d, rdlength - 2);
+ if (!rr->sshfp.key) {
+ r = -ENOMEM;
+ goto fail;
+ }
+
+ rr->sshfp.key_size = rdlength - 2;
+ break;
+
default:
+ unparseable:
r = dns_packet_read(p, rdlength, &d, NULL);
if (r < 0)
goto fail;