#include "dhcp-lease-internal.h"
#include "sd-dhcp-lease.h"
#include "sd-dhcp-client.h"
+#include "network-internal.h"
int sd_dhcp_lease_get_address(sd_dhcp_lease *lease, struct in_addr *addr) {
assert_return(lease, -EINVAL);
assert_return(lease, -EINVAL);
assert_return(addr, -EINVAL);
- addr->s_addr = lease->router;
+ if (lease->router != INADDR_ANY)
+ addr->s_addr = lease->router;
+ else
+ return -ENOENT;
return 0;
}
free(lease->hostname);
free(lease->domainname);
free(lease->dns);
+ free(lease->ntp);
free(lease);
}
if (!lease)
return -ENOMEM;
+ lease->router = INADDR_ANY;
lease->n_ref = REFCNT_INIT;
*ret = lease;
int dhcp_lease_save(sd_dhcp_lease *lease, const char *lease_file) {
_cleanup_free_ char *temp_path = NULL;
_cleanup_fclose_ FILE *f = NULL;
- char buf[INET_ADDRSTRLEN];
struct in_addr address;
+ struct in_addr *addresses;
+ size_t addresses_size;
const char *string;
uint16_t mtu;
int r;
if (r < 0)
goto finish;
- string = inet_ntop(AF_INET, &address, buf, INET_ADDRSTRLEN);
- if (!string) {
- r = -errno;
- goto finish;
- }
-
fprintf(f,
"# This is private data. Do not parse.\n"
- "ADDRESS=%s\n", string);
-
- r = sd_dhcp_lease_get_router(lease, &address);
- if (r < 0)
- goto finish;
-
- string = inet_ntop(AF_INET, &address, buf, INET_ADDRSTRLEN);
- if (!string) {
- r = -errno;
- goto finish;
- }
-
- fprintf(f,
- "ROUTER=%s\n", string);
+ "ADDRESS=%s\n", inet_ntoa(address));
r = sd_dhcp_lease_get_netmask(lease, &address);
if (r < 0)
goto finish;
- string = inet_ntop(AF_INET, &address, buf, INET_ADDRSTRLEN);
- if (!string) {
- r = -errno;
- goto finish;
- }
+ fprintf(f, "NETMASK=%s\n", inet_ntoa(address));
- fprintf(f,
- "NETMASK=%s\n", string);
+ r = sd_dhcp_lease_get_router(lease, &address);
+ if (r >= 0)
+ fprintf(f, "ROUTER=%s\n", inet_ntoa(address));
r = sd_dhcp_lease_get_server_identifier(lease, &address);
- if (r >= 0) {
- string = inet_ntop(AF_INET, &address, buf, INET_ADDRSTRLEN);
- if (!string) {
- r = -errno;
- goto finish;
- }
-
- fprintf(f,
- "SERVER_ADDRESS=%s\n", string);
- }
+ if (r >= 0)
+ fprintf(f, "SERVER_ADDRESS=%s\n",
+ inet_ntoa(address));
r = sd_dhcp_lease_get_next_server(lease, &address);
- if (r >= 0) {
- string = inet_ntop(AF_INET, &address, buf, INET_ADDRSTRLEN);
- if (!string) {
- r = -errno;
- goto finish;
- }
-
- fprintf(f,
- "NEXT_SERVER=%s\n", string);
- }
+ if (r >= 0)
+ fprintf(f, "NEXT_SERVER=%s\n", inet_ntoa(address));
r = sd_dhcp_lease_get_mtu(lease, &mtu);
if (r >= 0)
fprintf(f, "MTU=%" PRIu16 "\n", mtu);
-/* TODO: DNS. See resolv.conf writing in network-manager.c */
+ r = sd_dhcp_lease_get_dns(lease, &addresses, &addresses_size);
+ if (r >= 0)
+ serialize_in_addrs(f, "DNS", addresses, addresses_size);
+
+ r = sd_dhcp_lease_get_ntp(lease, &addresses, &addresses_size);
+ if (r >= 0)
+ serialize_in_addrs(f, "NTP", addresses, addresses_size);
r = sd_dhcp_lease_get_domainname(lease, &string);
if (r >= 0)
_cleanup_dhcp_lease_unref_ sd_dhcp_lease *lease = NULL;
_cleanup_free_ char *address = NULL, *router = NULL, *netmask = NULL,
*server_address = NULL, *next_server = NULL,
- *mtu = NULL;
+ *dns = NULL, *ntp = NULL, *mtu = NULL;
struct in_addr addr;
int r;
"NETMASK", &netmask,
"SERVER_IDENTIFIER", &server_address,
"NEXT_SERVER", &next_server,
+ "DNS", &dns,
+ "NTP", &ntp,
"MTU", &mtu,
"DOMAINNAME", &lease->domainname,
"HOSTNAME", &lease->hostname,
lease->address = addr.s_addr;
- r = inet_pton(AF_INET, router, &addr);
- if (r < 0)
- return r;
+ if (router) {
+ r = inet_pton(AF_INET, router, &addr);
+ if (r < 0)
+ return r;
- lease->router = addr.s_addr;
+ lease->router = addr.s_addr;
+ }
r = inet_pton(AF_INET, netmask, &addr);
if (r < 0)
lease->next_server = addr.s_addr;
}
+ if (dns) {
+ r = deserialize_in_addrs(&lease->dns, &lease->dns_size, dns);
+ if (r < 0)
+ return r;
+ }
+
+ if (ntp) {
+ r = deserialize_in_addrs(&lease->ntp, &lease->ntp_size, dns);
+ if (r < 0)
+ return r;
+ }
+
if (mtu) {
uint16_t u;
if (sscanf(mtu, "%" SCNu16, &u) > 0)