bus: implement basic name registration with kdbus

[elogind.git] / src / libsystemd-bus / bus-kernel.c

diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c
index 3d26f16cda7866f3149d973e62bf94a0b55b6cad..9d0be7a1908090be4895cc77a79555449eaa4e93 100644 (file)
--- a/src/libsystemd-bus/bus-kernel.c
+++ b/src/libsystemd-bus/bus-kernel.c
@@ -19,6 +19,10 @@
   along with systemd; If not, see <http://www.gnu.org/licenses/>.
 ***/
 
+#ifdef HAVE_VALGRIND_MEMCHECK_H
+#include <valgrind/memcheck.h>
+#endif
+
 #include <fcntl.h>
 
 #include "util.h"
@@ -32,8 +36,6 @@
              (uint8_t*) (d) < (uint8_t*) (k) + (k)->size;               \
              (d) = (struct kdbus_msg_data*) ((uint8_t*) (d) + ALIGN8((d)->size)))
 
-
-
 static int parse_unique_name(const char *s, uint64_t *id) {
         int r;
 
@@ -156,6 +158,9 @@ int bus_kernel_take_fd(sd_bus *b) {
 
         assert(b);
 
+        if (b->is_server)
+                return -EINVAL;
+
         r = ioctl(b->input_fd, KDBUS_CMD_HELLO, &hello);
         if (r < 0)
                 return -errno;
@@ -164,6 +169,7 @@ int bus_kernel_take_fd(sd_bus *b) {
                 return -ENOMEM;
 
         b->is_kernel = true;
+        b->bus_client = true;
 
         r = bus_start_running(b);
         if (r < 0)
@@ -178,6 +184,9 @@ int bus_kernel_connect(sd_bus *b) {
         assert(b->output_fd < 0);
         assert(b->kernel);
 
+        if (b->is_server)
+                return -EINVAL;
+
         b->input_fd = open(b->kernel, O_RDWR|O_NOCTTY|O_CLOEXEC);
         if (b->input_fd < 0)
                 return -errno;
@@ -225,6 +234,7 @@ static int bus_kernel_make_message(sd_bus *bus, struct kdbus_msg *k, sd_bus_mess
         struct bus_header *h = NULL;
         size_t total, n_bytes = 0, idx = 0;
         struct kdbus_creds *creds = NULL;
+        uint64_t nsec = 0;
         int r;
 
         assert(bus);
@@ -266,6 +276,8 @@ static int bus_kernel_make_message(sd_bus *bus, struct kdbus_msg *k, sd_bus_mess
 
                 } else if (d->type == KDBUS_MSG_SRC_CREDS)
                         creds = &d->creds;
+                else if (d->type == KDBUS_MSG_TIMESTAMP)
+                        nsec = d->ts_ns;
         }
 
         if (!h)
@@ -313,6 +325,8 @@ static int bus_kernel_make_message(sd_bus *bus, struct kdbus_msg *k, sd_bus_mess
                 m->uid_valid = m->gid_valid = true;
         }
 
+        m->timestamp = nsec / NSEC_PER_USEC;
+
         r = bus_message_parse_fields(m);
         if (r < 0) {
                 sd_bus_message_unref(m);
@@ -332,7 +346,7 @@ static int bus_kernel_make_message(sd_bus *bus, struct kdbus_msg *k, sd_bus_mess
 
 int bus_kernel_read_message(sd_bus *bus, sd_bus_message **m) {
         struct kdbus_msg *k;
-        size_t sz = 128;
+        size_t sz = 1024;
         int r;
 
         assert(bus);
@@ -348,6 +362,13 @@ int bus_kernel_read_message(sd_bus *bus, sd_bus_message **m) {
                 k = bus->rbuffer = q;
                 k->size = sz;
 
+                /* Let's tell valgrind that there's really no need to
+                 * initialize this fully. This should be removed again
+                 * when valgrind learned the kdbus ioctls natively. */
+#ifdef HAVE_VALGRIND_MEMCHECK_H
+                VALGRIND_MAKE_MEM_DEFINED(k, sz);
+#endif
+
                 r = ioctl(bus->input_fd, KDBUS_CMD_MSG_RECV, bus->rbuffer);
                 if (r >= 0)
                         break;