coredumpctl: fix potential deref of null pointer

[elogind.git] / src / journal / coredump.c

diff --git a/src/journal/coredump.c b/src/journal/coredump.c
index bb6dcba0406f7523dfa3c20db7635006c51063bb..ab8fd2cf0e9acaca372e644d5b779c90fa0953e7 100644 (file)
--- a/src/journal/coredump.c
+++ b/src/journal/coredump.c
@@ -345,16 +345,16 @@ static int save_external_coredump(const char *info[_INFO_LEN],
                 goto fail;
         }
 
-        if (lseek(fd, 0, SEEK_SET) == (off_t) -1) {
-                log_error("Failed to seek on %s: %m", tmp);
-                goto uncompressed;
-        }
-
         if (fstat(fd, &st) < 0) {
                 log_error("Failed to fstat coredump %s: %m", tmp);
                 goto fail;
         }
 
+        if (lseek(fd, 0, SEEK_SET) == (off_t) -1) {
+                log_error("Failed to seek on %s: %m", tmp);
+                goto uncompressed;
+        }
+
 #ifdef HAVE_XZ
         /* If we will remove the coredump anyway, do not compress. */
         if (maybe_remove_external_coredump(NULL, st.st_size) == 0
@@ -500,7 +500,7 @@ int main(int argc, char* argv[]) {
         log_debug("Selected storage '%s'.",
                   coredump_storage_to_string(arg_storage));
         log_debug("Selected compression %s:%u.",
-                  coredump_compression_to_string(arg_storage),
+                  coredump_compression_to_string(arg_compression),
                   arg_compression_level);
 
         r = parse_uid(argv[INFO_UID + 1], &uid);