chiark / gitweb /
cdrom_id: request the drive profile features with a dynamic length
[elogind.git] / extras / cdrom_id / cdrom_id.c
index f9d6e0bc24fe574aef4cc86189b516e553892567..ec001cde713a291f182844ec11453f08b66e24b0 100644 (file)
@@ -297,14 +297,9 @@ static int feature_profiles(struct udev *udev, const unsigned char *profiles, si
                        cd_dvd_ram = 1;
                        break;
                case 0x13:
-                       info(udev, "profile 0x%02x media_dvd_rw\n", profile);
-                       cd_media_dvd_rw = 1;
-                       cd_media_dvd_rw_ro = 1;
-                       break;
                case 0x14:
                        info(udev, "profile 0x%02x dvd_rw\n", profile);
                        cd_dvd_rw = 1;
-                       cd_media_dvd_rw_seq = 1;
                        break;
                case 0x1B:
                        info(udev, "profile 0x%02x dvd_plus_r\n", profile);
@@ -369,8 +364,14 @@ static int cd_profiles_old_mmc(struct udev *udev, int fd)
        err = scsi_cmd_run(udev, &sc, fd, header, sizeof(header));
        if ((err != 0)) {
                info_scsi_cmd_err(udev, "READ DISC INFORMATION", err);
-               info(udev, "no current profile, assuming no media\n");
-               return -1;
+               if (cd_media == 1) {
+                       info(udev, "no current profile, but disc is present; assuming CD-ROM\n");
+                       cd_media_cd_rom = 1;
+                       return 0;
+               } else {
+                       info(udev, "no current profile, assuming no media\n");
+                       return -1;
+               }
        };
 
        cd_media = 1;
@@ -397,12 +398,12 @@ static int cd_profiles(struct udev *udev, int fd)
        unsigned int i;
        int err;
 
+       /* First query the current profile */
        scsi_cmd_init(udev, &sc, features, sizeof(features));
        scsi_cmd_set(udev, &sc, 0, 0x46);
-       scsi_cmd_set(udev, &sc, 7, (sizeof(features) >> 8) & 0xff);
-       scsi_cmd_set(udev, &sc, 8, sizeof(features) & 0xff);
+       scsi_cmd_set(udev, &sc, 8, 8);
        scsi_cmd_set(udev, &sc, 9, 0);
-       err = scsi_cmd_run(udev, &sc, fd, features, sizeof(features));
+       err = scsi_cmd_run(udev, &sc, fd, features, 8);
        if ((err != 0)) {
                info_scsi_cmd_err(udev, "GET CONFIGURATION", err);
                /* handle pre-MMC2 drives which do not support GET CONFIGURATION */
@@ -414,31 +415,6 @@ static int cd_profiles(struct udev *udev, int fd)
                return -1;
        }
 
-       len = features[0] << 24 | features[1] << 16 | features[2] << 8 | features[3];
-       info(udev, "GET CONFIGURATION: size of features buffer 0x%04x\n", len);
-
-       if (len > sizeof(features)) {
-               info(udev, "can not get features in a single query, truncating\n");
-               len = sizeof(features);
-       }
-
-       /* device features */
-       for (i = 8; i+4 < len; i += (4 + features[i+3])) {
-               unsigned int feature;
-
-               feature = features[i] << 8 | features[i+1];
-
-               switch (feature) {
-               case 0x00:
-                       info(udev, "GET CONFIGURATION: feature 'profiles', with %i entries\n", features[i+3] / 4);
-                       feature_profiles(udev, &features[i]+4, features[i+3]);
-                       break;
-               default:
-                       info(udev, "GET CONFIGURATION: feature 0x%04x <ignored>, with 0x%02x bytes\n", feature, features[i+3]);
-                       break;
-               }
-       }
-
        cur_profile = features[6] << 8 | features[7];
        if (cur_profile > 0) {
                info(udev, "current profile 0x%02x\n", cur_profile);
@@ -486,10 +462,16 @@ static int cd_profiles(struct udev *udev, int fd)
                cd_media_dvd_ram = 1;
                break;
        case 0x13:
+               info(udev, "profile 0x%02x media_dvd_rw_ro\n", cur_profile);
+               cd_media = 1;
+               cd_media_dvd_rw = 1;
+               cd_media_dvd_rw_ro = 1;
+               break;
        case 0x14:
-               info(udev, "profile 0x%02x media_dvd_rw\n", cur_profile);
+               info(udev, "profile 0x%02x media_dvd_rw_seq\n", cur_profile);
                cd_media = 1;
                cd_media_dvd_rw = 1;
+               cd_media_dvd_rw_seq = 1;
                break;
        case 0x1B:
                info(udev, "profile 0x%02x media_dvd_plus_r\n", cur_profile);
@@ -546,6 +528,56 @@ static int cd_profiles(struct udev *udev, int fd)
                info(udev, "profile 0x%02x <ignored>\n", cur_profile);
                break;
        }
+
+
+       len = features[0] << 24 | features[1] << 16 | features[2] << 8 | features[3];
+       info(udev, "GET CONFIGURATION: size of features buffer 0x%04x\n", len);
+
+       if (len > sizeof(features)) {
+               info(udev, "can not get features in a single query, truncating\n");
+               len = sizeof(features);
+       } else if (len <= 8) {
+               len = sizeof(features);
+       }
+
+       /* Now get the full feature buffer */
+       scsi_cmd_init(udev, &sc, features,  len);
+       scsi_cmd_set(udev, &sc, 0, 0x46);
+       scsi_cmd_set(udev, &sc, 7, ( len >> 8 ) & 0xff);
+       scsi_cmd_set(udev, &sc, 8, len & 0xff);
+       scsi_cmd_set(udev, &sc, 9, 0);
+       err = scsi_cmd_run(udev, &sc, fd, features, len);
+       if ((err != 0)) {
+               info_scsi_cmd_err(udev, "GET CONFIGURATION", err);
+               return -1;
+       }
+
+       /* parse the length once more, in case the drive decided to have other features suddenly :) */
+       len = features[0] << 24 | features[1] << 16 | features[2] << 8 | features[3];
+       info(udev, "GET CONFIGURATION: size of features buffer 0x%04x\n", len);
+
+       if (len > sizeof(features)) {
+               info(udev, "can not get features in a single query, truncating\n");
+               len = sizeof(features);
+       }
+
+       /* device features */
+       for (i = 8; i+4 < len; i += (4 + features[i+3])) {
+               unsigned int feature;
+
+               feature = features[i] << 8 | features[i+1];
+
+               switch (feature) {
+               case 0x00:
+                       info(udev, "GET CONFIGURATION: feature 'profiles', with %i entries\n", features[i+3] / 4);
+                       feature_profiles(udev, &features[i]+4, features[i+3]);
+                       break;
+               default:
+                       info(udev, "GET CONFIGURATION: feature 0x%04x <ignored>, with 0x%02x bytes\n", feature, features[i+3]);
+                       break;
+               }
+       }
+
        return 0;
 }
 
@@ -589,7 +621,7 @@ static int cd_media_info(struct udev *udev, int fd)
         * always "complete", DVD-RAM are "other" or "complete" if the disc is
         * write protected; we need to check the contents if it is blank */
        if ((cd_media_dvd_rw_ro || cd_media_dvd_plus_rw || cd_media_dvd_plus_rw_dl || cd_media_dvd_ram) && (header[2] & 3) > 1) {
-               unsigned char buffer[17 * 2048];
+               unsigned char buffer[32 * 2048];
                unsigned char result, len;
                int block, offset;
 
@@ -660,7 +692,7 @@ static int cd_media_info(struct udev *udev, int fd)
                scsi_cmd_init(udev, &sc, buffer, sizeof(buffer));
                scsi_cmd_set(udev, &sc, 0, 0x28);
                scsi_cmd_set(udev, &sc, 5, 0);
-               scsi_cmd_set(udev, &sc, 8, 17);
+               scsi_cmd_set(udev, &sc, 8, 32);
                scsi_cmd_set(udev, &sc, 9, 0);
                err = scsi_cmd_run(udev, &sc, fd, buffer, sizeof(buffer));
                if ((err != 0)) {
@@ -705,7 +737,7 @@ static int cd_media_toc(struct udev *udev, int fd)
        struct scsi_cmd sc;
        unsigned char header[12];
        unsigned char toc[2048];
-       unsigned int len, i;
+       unsigned int len, i, num_tracks;
        unsigned char *p;
        int err;
 
@@ -721,11 +753,13 @@ static int cd_media_toc(struct udev *udev, int fd)
        }
 
        len = (header[0] << 8 | header[1]) + 2;
-       info(udev, "READ TOC: len: %d\n", len);
+       info(udev, "READ TOC: len: %d, start track: %d, end track: %d\n", len, header[2], header[3]);
        if (len > sizeof(toc))
                return -1;
        if (len < 2)
                return -1;
+       /* 2: first track, 3: last track */
+       num_tracks = header[3] - header[2] + 1;
 
        /* empty media has no tracks */
        if (len < 8)
@@ -743,7 +777,10 @@ static int cd_media_toc(struct udev *udev, int fd)
                return -1;
        }
 
-       for (p = toc+4, i = 4; i < len-8; i += 8, p += 8) {
+       /* Take care to not iterate beyond the last valid track as specified in
+        * the TOC, but also avoid going beyond the TOC length, just in case
+        * the last track number is invalidly large */
+       for (p = toc+4, i = 4; i < len-8 && num_tracks > 0; i += 8, p += 8, --num_tracks) {
                unsigned int block;
                unsigned int is_data_track;