chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
btrfs-util: fix creating recursive read-only snapshots
[elogind.git]
/
src
/
shared
/
machine-image.c
diff --git
a/src/shared/machine-image.c
b/src/shared/machine-image.c
index 552847e0f0119890255d3244629dcecd3cbd8d41..bc215f0ad5ca60e60d8fa600c6879717c354d65c 100644
(file)
--- a/
src/shared/machine-image.c
+++ b/
src/shared/machine-image.c
@@
-28,6
+28,7
@@
#include "path-util.h"
#include "copy.h"
#include "mkdir.h"
#include "path-util.h"
#include "copy.h"
#include "mkdir.h"
+#include "rm-rf.h"
#include "machine-image.h"
static const char image_search_path[] =
#include "machine-image.h"
static const char image_search_path[] =
@@
-135,12
+136,11
@@
static int image_make(
/* btrfs subvolumes have inode 256 */
if (st.st_ino == 256) {
/* btrfs subvolumes have inode 256 */
if (st.st_ino == 256) {
- struct statfs sfs;
- if (fstatfs(fd, &sfs) < 0)
- return -errno;
-
- if (
F_TYPE_EQUAL(sfs.f_type, BTRFS_SUPER_MAGIC)
) {
+ r = btrfs_is_filesystem(fd);
+ if (r < 0)
+ return r;
+ if (
r
) {
BtrfsSubvolInfo info;
BtrfsQuotaInfo quota;
BtrfsSubvolInfo info;
BtrfsQuotaInfo quota;
@@
-357,19
+357,21
@@
int image_remove(Image *i) {
switch (i->type) {
case IMAGE_SUBVOLUME:
switch (i->type) {
case IMAGE_SUBVOLUME:
- return btrfs_subvol_remove(i->path);
+ return btrfs_subvol_remove(i->path
, true
);
case IMAGE_DIRECTORY:
/* Allow deletion of read-only directories */
(void) chattr_path(i->path, false, FS_IMMUTABLE_FL);
case IMAGE_DIRECTORY:
/* Allow deletion of read-only directories */
(void) chattr_path(i->path, false, FS_IMMUTABLE_FL);
-
- /* fall through */
+ return rm_rf(i->path, REMOVE_ROOT|REMOVE_PHYSICAL|REMOVE_SUBVOLUME);
case IMAGE_RAW:
case IMAGE_RAW:
- return rm_rf_dangerous(i->path, false, true, false);
+ if (unlink(i->path) < 0)
+ return -errno;
+
+ return 0;
default:
default:
- return -E
NOTSU
P;
+ return -E
OPNOTSUP
P;
}
}
}
}
@@
-430,7
+432,7
@@
int image_rename(Image *i, const char *new_name) {
}
default:
}
default:
- return -E
NOTSU
P;
+ return -E
OPNOTSUP
P;
}
if (!new_path)
}
if (!new_path)
@@
-440,8
+442,9
@@
int image_rename(Image *i, const char *new_name) {
if (!nn)
return -ENOMEM;
if (!nn)
return -ENOMEM;
- if (renameat2(AT_FDCWD, i->path, AT_FDCWD, new_path, RENAME_NOREPLACE) < 0)
- return -errno;
+ r = rename_noreplace(AT_FDCWD, i->path, AT_FDCWD, new_path);
+ if (r < 0)
+ return r;
/* Restore the immutable bit, if it was set before */
if (file_attr & FS_IMMUTABLE_FL)
/* Restore the immutable bit, if it was set before */
if (file_attr & FS_IMMUTABLE_FL)
@@
-487,7
+490,7
@@
int image_clone(Image *i, const char *new_name, bool read_only) {
case IMAGE_DIRECTORY:
new_path = strjoina("/var/lib/machines/", new_name);
case IMAGE_DIRECTORY:
new_path = strjoina("/var/lib/machines/", new_name);
- r = btrfs_subvol_snapshot(i->path, new_path,
read_only, true
);
+ r = btrfs_subvol_snapshot(i->path, new_path,
(read_only ? BTRFS_SNAPSHOT_READ_ONLY : 0) | BTRFS_SNAPSHOT_FALLBACK_COPY | BTRFS_SNAPSHOT_RECURSIVE
);
break;
case IMAGE_RAW:
break;
case IMAGE_RAW:
@@
-497,7
+500,7
@@
int image_clone(Image *i, const char *new_name, bool read_only) {
break;
default:
break;
default:
- return -E
NOTSU
P;
+ return -E
OPNOTSUP
P;
}
if (r < 0)
}
if (r < 0)
@@
-562,7
+565,7
@@
int image_read_only(Image *i, bool b) {
}
default:
}
default:
- return -E
NOTSU
P;
+ return -E
OPNOTSUP
P;
}
return 0;
}
return 0;
@@
-621,7
+624,7
@@
int image_set_limit(Image *i, uint64_t referenced_max) {
return -EROFS;
if (i->type != IMAGE_SUBVOLUME)
return -EROFS;
if (i->type != IMAGE_SUBVOLUME)
- return -E
NOTSU
P;
+ return -E
OPNOTSUP
P;
return btrfs_quota_limit(i->path, referenced_max);
}
return btrfs_quota_limit(i->path, referenced_max);
}