chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
tmpfiles: move legacy flag-files handling to legacy.conf
[elogind.git]
/
src
/
python-systemd
/
_journal.c
diff --git
a/src/python-systemd/_journal.c
b/src/python-systemd/_journal.c
index c305b77ce298aefb276ebbf9fecd6144bfdcf087..0bdf709aeacaa6c94712fc00e1f33e62c58ec940 100644
(file)
--- a/
src/python-systemd/_journal.c
+++ b/
src/python-systemd/_journal.c
@@
-21,6
+21,8
@@
#include <Python.h>
#include <Python.h>
+#include <alloca.h>
+
#define SD_JOURNAL_SUPPRESS_LOCATION
#include <systemd/sd-journal.h>
#define SD_JOURNAL_SUPPRESS_LOCATION
#include <systemd/sd-journal.h>
@@
-36,20
+38,13
@@
static PyObject *journal_sendv(PyObject *self, PyObject *args) {
PyObject *ret = NULL;
PyObject **encoded;
PyObject *ret = NULL;
PyObject **encoded;
+ /* Allocate an array for the argument strings */
argc = PyTuple_Size(args);
argc = PyTuple_Size(args);
-
- encoded = calloc(argc, sizeof(PyObject*));
- if (!encoded) {
- ret = PyErr_NoMemory();
- goto out1;
- }
+ encoded = alloca(argc * sizeof(PyObject*));
+ memset(encoded, 0, argc * sizeof(PyObject*));
/* Allocate sufficient iovector space for the arguments. */
/* Allocate sufficient iovector space for the arguments. */
- iov = malloc(argc * sizeof(struct iovec));
- if (!iov) {
- ret = PyErr_NoMemory();
- goto out;
- }
+ iov = alloca(argc * sizeof(struct iovec));
/* Iterate through the Python arguments and fill the iovector. */
for (i = 0; i < argc; ++i) {
/* Iterate through the Python arguments and fill the iovector. */
for (i = 0; i < argc; ++i) {
@@
-70,17
+65,11
@@
static PyObject *journal_sendv(PyObject *self, PyObject *args) {
iov[i].iov_len = length;
}
iov[i].iov_len = length;
}
- /* Clear errno, because sd_journal_sendv will not set it by
- itself, unless an error occurs in one of the system calls. */
- errno = 0;
-
/* Send the iovector to the journal. */
r = sd_journal_sendv(iov, argc);
/* Send the iovector to the journal. */
r = sd_journal_sendv(iov, argc);
- if (r) {
- if (errno)
- PyErr_SetFromErrno(PyExc_IOError);
- else
- PyErr_SetString(PyExc_ValueError, "invalid message format");
+ if (r < 0) {
+ errno = -r;
+ PyErr_SetFromErrno(PyExc_IOError);
goto out;
}
goto out;
}
@@
-92,13
+81,6
@@
out:
for (i = 0; i < argc; ++i)
Py_XDECREF(encoded[i]);
for (i = 0; i < argc; ++i)
Py_XDECREF(encoded[i]);
- free(encoded);
-
-out1:
- /* Free the iovector. The actual strings
- are already managed by Python. */
- free(iov);
-
return ret;
}
return ret;
}
@@
-117,8
+99,10
@@
static PyObject* journal_stream_fd(PyObject *self, PyObject *args) {
return NULL;
fd = sd_journal_stream_fd(identifier, priority, level_prefix);
return NULL;
fd = sd_journal_stream_fd(identifier, priority, level_prefix);
- if (fd < 0)
+ if (fd < 0) {
+ errno = -fd;
return PyErr_SetFromErrno(PyExc_IOError);
return PyErr_SetFromErrno(PyExc_IOError);
+ }
return PyLong_FromLong(fd);
}
return PyLong_FromLong(fd);
}
@@
-129,6
+113,9
@@
static PyMethodDef methods[] = {
{ NULL, NULL, 0, NULL } /* Sentinel */
};
{ NULL, NULL, 0, NULL } /* Sentinel */
};
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+
#if PY_MAJOR_VERSION < 3
PyMODINIT_FUNC init_journal(void) {
#if PY_MAJOR_VERSION < 3
PyMODINIT_FUNC init_journal(void) {
@@
-150,3
+137,5
@@
PyMODINIT_FUNC PyInit__journal(void) {
}
#endif
}
#endif
+
+#pragma GCC diagnostic pop