From: Simon Tatham Date: Tue, 17 Mar 2020 18:12:33 +0000 (+0000) Subject: Mines: add validation for negative mine count. X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=d71ac73d8a4397c35b21ec08388a1c6f94691b64;p=sgt-puzzles.git Mines: add validation for negative mine count. If this gets through validation, it causes an infinite loop after gameplay begins. --- diff --git a/mines.c b/mines.c index 00d306c..ee2d5bb 100644 --- a/mines.c +++ b/mines.c @@ -258,6 +258,8 @@ static const char *validate_params(const game_params *params, bool full) */ if (full && params->unique && (params->w <= 2 || params->h <= 2)) return "Width and height must both be greater than two"; + if (params->n < 0) + return "Mine count may not be negative"; if (params->n > params->w * params->h - 9) return "Too many mines for grid size";