From: Simon Tatham Date: Fri, 29 Jul 2005 11:34:02 +0000 (+0000) Subject: Ben Hutchings reports that gcc 4 gives an optimiser warning because X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=b0adb79178a5a00e843c6ac27ce0e1bcd2bec9d8;p=sgt-puzzles.git Ben Hutchings reports that gcc 4 gives an optimiser warning because it can't tell that one branch of a particular switch is always taken. Adding a default clause with an automatic assertion failure apparently fixes it. [originally from svn r6148] --- diff --git a/rect.c b/rect.c index a7113af..439ae1f 100644 --- a/rect.c +++ b/rect.c @@ -1348,6 +1348,8 @@ static char *new_game_desc(game_params *params, random_state *rs, r1.x++; r1.w--; break; + default: /* should never happen */ + assert(!"invalid direction"); } if (r1.h > 0 && r1.w > 0) place_rect(params2, grid, r1);