From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 1 Aug 2021 19:18:00 +0000 (+0100)
Subject: fix slip mimeification
X-Git-Tag: hippotat/1.0.0~391
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=ab962474c63cfcfd89d5e9d886be8c49e07b8021;p=hippotat.git

fix slip mimeification

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/slip.rs b/src/slip.rs
index acd863d..817357b 100644
--- a/src/slip.rs
+++ b/src/slip.rs
@@ -14,19 +14,27 @@ pub fn check_checkmtu_mimeswap<const TO_MIME: bool>
 
   for mut packet in data.split_mut(|&c| c == SLIP_END) {
     if packet.len() > mtu.sat() {
-      throw!(anyhow!("mtu exceeded ({} > {})", packet.len(), mtu));
+      throw!(anyhow!("MTU exceeded ({} > {})", packet.len(), mtu));
     }
 
-    while let Some((i, _)) = packet.iter().enumerate().find(
-      |(_,&c)| c == if TO_MIME { SLIP_ESC } else { SLIP_MIME_ESC }
+    while let Some((i, was_mime)) = packet.iter().enumerate().find_map(
+      |(i,&c)| match c {
+        SLIP_MIME_ESC => Some((i,true)),
+        SLIP_ESC      => Some((i,false)),
+        _ => None,
+      }
     ) {
-      packet[i] = if TO_MIME { SLIP_MIME_ESC } else { SLIP_ESC };
-      match packet.get(i+1) {
-        Some(&SLIP_ESC_END) |
-        Some(&SLIP_ESC_ESC) => Ok(()),
-        _ => Err(anyhow!("SLIP escape not followed by ESC_END or ESC_ESC")),
-      }?;
-      packet = &mut packet[i+2 ..];
+      packet[i] = if was_mime { SLIP_ESC } else { SLIP_MIME_ESC };
+      if was_mime != TO_MIME {
+        match packet.get(i+1) {
+          Some(&SLIP_ESC_END) |
+          Some(&SLIP_ESC_ESC) => Ok(()),
+          _ => Err(anyhow!("SLIP escape not followed by ESC_END or ESC_ESC")),
+        }?;
+        packet = &mut packet[i+2 ..];
+      } else {
+        packet = &mut packet[i+1 ..];
+      }
     }
   }
 
@@ -64,6 +72,7 @@ impl From<Frames> for FramesData {
   fn from(frames: Frames) -> FramesData { frames.frames }
 }
 
+#[derive(Copy,Clone,Eq,PartialEq,Ord,PartialOrd,Hash)]
 pub struct DumpHex<'b>(pub &'b [u8]);
 impl Debug for DumpHex<'_> {
   #[throws(fmt::Error)]
@@ -77,7 +86,7 @@ fn mime_slip_to_mime() {
   fn chk(i: &[u8], exp: Result<&[u8], &str>) {
     let mut p = i.to_owned();
     match (exp, check_checkmtu_mimeswap::<true>(10, p.as_mut())) {
-      (Ok(exp), Ok(())) => assert_eq!( exp, &p ),
+      (Ok(exp), Ok(())) => assert_eq!( DumpHex(exp), DumpHex(&p) ),
       (Err(exp), Err(got)) => assert!( got.to_string().contains(exp) ),
       x => panic!("? {:?}", x),
     }
@@ -87,4 +96,9 @@ fn mime_slip_to_mime() {
     Ok(&[ SLIP_END, b'-',     SLIP_ESC_END, SLIP_ESC, b'X' ]) );
 
   chk( &[ SLIP_END, SLIP_ESC, b'y' ], Err("SLIP escape") );
+
+  chk( &[ SLIP_END, b'-',     b'y' ],
+    Ok(&[ SLIP_END, SLIP_ESC, b'y' ]) );
+
+  chk( &[b'x'; 20], Err("MTU"));
 }