From: Simon Tatham Date: Fri, 5 Apr 2013 15:49:24 +0000 (+0000) Subject: Stop accidentally subtracting onscreen_canvas.offset{Left,Top} from X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=7479c2882dfa7c3b75653c728ade1997734f3d01;p=sgt-puzzles.git Stop accidentally subtracting onscreen_canvas.offset{Left,Top} from the return value of relative_mouse_coords! I only got away with that error because the canvas was at offset zero compared to its immediate parent element. [originally from svn r9808] --- diff --git a/emccpre.js b/emccpre.js index 38d7815..66e6354 100644 --- a/emccpre.js +++ b/emccpre.js @@ -135,9 +135,7 @@ function initPuzzle() { buttons_down = 0; onscreen_canvas.onmousedown = function(event) { var xy = relative_mouse_coords(event, onscreen_canvas); - mousedown(xy.x - onscreen_canvas.offsetLeft, - xy.y - onscreen_canvas.offsetTop, - event.button); + mousedown(xy.x, xy.y, event.button); buttons_down |= 1 << event.button; onscreen_canvas.setCapture(true); }; @@ -146,9 +144,7 @@ function initPuzzle() { onscreen_canvas.onmousemove = function(event) { if (buttons_down) { var xy = relative_mouse_coords(event, onscreen_canvas); - mousemove(xy.x - onscreen_canvas.offsetLeft, - xy.y - onscreen_canvas.offsetTop, - buttons_down); + mousemove(xy.x, xy.y, buttons_down); } }; mouseup = Module.cwrap('mouseup', 'void', @@ -157,9 +153,7 @@ function initPuzzle() { if (buttons_down & (1 << event.button)) { buttons_down ^= 1 << event.button; var xy = relative_mouse_coords(event, onscreen_canvas); - mouseup(xy.x - onscreen_canvas.offsetLeft, - xy.y - onscreen_canvas.offsetTop, - event.button); + mouseup(xy.x, xy.y, event.button); } };