From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 5 Aug 2021 00:08:11 +0000 (+0100)
Subject: config: Fix algorithm problem with instance enumration
X-Git-Tag: hippotat/1.0.0~321
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=6a5416ef8925fba0d5e067a92249aaa45d438b33;p=hippotat.git

config: Fix algorithm problem with instance enumration

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/config.rs b/src/config.rs
index dd4950e..76e98bf 100644
--- a/src/config.rs
+++ b/src/config.rs
@@ -431,10 +431,14 @@ impl Aggregate {
     // Add links which are justified by blanket secrets
     for (client, server) in iproduct!(
       putative_clients.into_iter().filter(
-        |c| secret_global || secrets_anyserver.contains(c)
+        |c| secret_global
+         || secrets_anyserver.contains(c)
+         || ! secrets_anyclient.is_empty()
       ),
       putative_servers.iter().cloned().filter(
-        |s| secret_global || secrets_anyclient.contains(s)
+        |s| secret_global
+         || secrets_anyclient.contains(s)
+         || ! secrets_anyserver.is_empty()
       )
     ) {
       links.insert(LinkName {
@@ -837,6 +841,8 @@ pub fn read(opts: &Opts, end: LinkEnd) -> Vec<InstanceConfig> {
       ],
     };
 
+    if rctx.first_of_raw("secret", SKL::Ordinary).is_none() { continue }
+
     let mut ic = InstanceConfig::resolve_instance(&rctx)
       .with_context(|| format!("resolve config for {}", &link))?;