From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 4 Aug 2021 18:24:17 +0000 (+0100)
Subject: filed MR for missing From<Box<>>
X-Git-Tag: hippotat/1.0.0~336
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=1069a739b45f85cbf51c7ef94b55137dab806bc9;p=hippotat.git

filed MR for missing From<Box<>>

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/bin/client.rs b/src/bin/client.rs
index 83fc74f..d454342 100644
--- a/src/bin/client.rs
+++ b/src/bin/client.rs
@@ -249,8 +249,8 @@ async fn run_client<C:HCC>(
            ! packets.is_empty() =>
         {
           while let Some(packet) = packets.pop_front() {
-            match upbound.add(ic.max_batch_up, packet.into()/*xxx*/) {
-              Err(packet) => { packets.push_front(packet.into()/*xxx*/); break; }
+            match upbound.add(ic.max_batch_up, packet.into()/*todo:504*/) {
+              Err(packet) => { packets.push_front(packet.into()/*todo:504*/); break; }
               Ok(()) => { },
             }
           }
diff --git a/src/slip.rs b/src/slip.rs
index 452634e..67b4d40 100644
--- a/src/slip.rs
+++ b/src/slip.rs
@@ -100,9 +100,12 @@ where AC: Fn(&[u8]) -> Result<(), PacketError>,
 
 pub type Frame = Vec<u8>;
 pub type FramesData = Vec<Vec<u8>>;
-//pub type Frame = Box<[u8]>;
-//pub type FramesData = Vec<Frame>;
-//  `From<Box<[u8]>>` is not implemented for `Bytes`
+// todo: https://github.com/tokio-rs/bytes/pull/504
+//   pub type Frame = Box<[u8]>;
+//   pub type FramesData = Vec<Frame>;
+//       `From<Box<[u8]>>` is not implemented for `Bytes`
+// when this is fixed, there are two `into`s in client.rs which 
+// become redundant (search for todo:504)
 
 
 #[derive(Default)]