chiark / gitweb /
tidy up errors
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Mon, 2 Aug 2021 00:51:58 +0000 (01:51 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Mon, 2 Aug 2021 00:51:58 +0000 (01:51 +0100)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
src/bin/client.rs
src/slip.rs

index 4d495198e078c318ba2eaed88da84ad3c7406c25..080ced93700972dd9dcf09c309732f5b48cc14e2 100644 (file)
@@ -199,10 +199,12 @@ async fn run_client<C:HCC>(
           packets = check
             ::<_,_,true>(ic.mtu, &data, |header| {
               let addr = ip_packet_addr::<false>(header)?;
-              if addr != ic.link.client.0 { throw!(PE::UnexpectedSrc(addr)) }
+              if addr != ic.link.client.0 { throw!(PE::Src(addr)) }
               Ok(())
             }, |e| match e {
-              e => error!("PACKET ERROR {}", e), // xxx
+              PE::Empty => { },
+              e@ PE::Src(_) => debug!("{}: tx: discarding: {}", &ic, e),
+              e => error!("{}: tx: discarding: {}", &ic, e),
             }).into();
         },
 
index 5e64d8e19a820bfdfeab0c8beef8429ea22d6195..c5b919b55ef8fb7ebd9c563e81432d1dd3498154 100644 (file)
@@ -11,8 +11,8 @@ pub enum PacketError {
   #[error("empty packet")]                 Empty,
   #[error("MTU exceeded ({len} > {mtu})")] MTU { len: usize, mtu: u32 },
   #[error("Invalid SLIP escape sequence")] SLIP,
-  #[error("unexpected src addr {0:?}")]    UnexpectedSrc(IpAddr),
-  #[error("unexpected dst addr {0:?}")]    UnexpectedDst(IpAddr),
+  #[error("unexpected src addr {0:?}")]    Src(IpAddr),
+  #[error("unexpected dst addr {0:?}")]    Dst(IpAddr),
   #[error("bad, IPv{vsn}, len={len}")]     Bad { len: usize, vsn: u8 },
 }