Fix GTK 2 crash introduced by previous commit.

Moving the snaffle_colours() call earlier is fine in GTK 3, where the
potential call to frontend_default_colour doesn't depend on the window
already having been created. But it falls over in GTK 2 where it does.

Moved the non-headless-mode version of that call back to where it was
before the --screenshot change.

diff --git a/gtk.c b/gtk.c
index c0bcb9525036d8e840617202a4960a12b0a12d66..d41f8677b983c9fb0d151aa6d6ba723513660733 100644 (file)
--- a/gtk.c
+++ b/gtk.c
@@ -2575,9 +2575,8 @@ static frontend *new_window(
        midend_new_game(fe->me);
     }
 
-    snaffle_colours(fe);
-
     if (headless) {
+        snaffle_colours(fe);
         get_size(fe, &fe->pw, &fe->ph);
         setup_backing_store(fe);
         return fe;
@@ -2790,6 +2789,8 @@ static frontend *new_window(
 
     changed_preset(fe);
 
+    snaffle_colours(fe);
+
     if (midend_wants_statusbar(fe->me)) {
        GtkWidget *viewport;
        GtkRequisition req;