From: Vladimír Vondruš <mosra@centrum.cz>
Date: Thu, 18 Jul 2019 17:30:10 +0000 (+0200)
Subject: documentation/python: um, why don't I use a function here?
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~cjwatson/git?a=commitdiff_plain;h=d3327c55c7f4b10297f1d2a744f66d8399a1ca5a;p=blog.git

documentation/python: um, why don't I use a function here?
---

diff --git a/documentation/python.py b/documentation/python.py
index e9e4a78a..6d7987c1 100755
--- a/documentation/python.py
+++ b/documentation/python.py
@@ -1290,7 +1290,7 @@ def extract_data_doc(state: State, parent, entry: Empty):
     out.name = entry.path[-1]
     out.id = state.config['ID_FORMATTER'](EntryType.DATA, entry.path[-1:])
     # Welp. https://stackoverflow.com/questions/8820276/docstring-for-variable
-    out.summary = ''
+    out.summary = extract_summary(state, state.data_docs, entry.path, '')
     out.has_details = False
 
     # First try to get fully dereferenced type hints (with strings converted to
@@ -1307,13 +1307,6 @@ def extract_data_doc(state: State, parent, entry: Empty):
 
     out.value = format_value(state, entry.path, entry.object)
 
-    # External data summary, if provided
-    path_str = '.'.join(entry.path)
-    if path_str in state.data_docs:
-        # TODO: use also the contents
-        out.summary = render_inline_rst(state, state.data_docs[path_str]['summary'])
-        del state.data_docs[path_str]
-
     if not state.config['SEARCH_DISABLED']:
         result = Empty()
         result.flags = ResultFlag.from_type(ResultFlag.NONE, EntryType.DATA)