From: Vladimír Vondruš Date: Tue, 7 May 2019 10:35:48 +0000 (+0200) Subject: documentation/python: don't cut off the last character in a warning. X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~cjwatson/git?a=commitdiff_plain;h=c1e474d9ef478fad505e3d3a5985f191f78fdc81;p=blog.git documentation/python: don't cut off the last character in a warning. I mistakenly thought a[:-1] is the same as a[:]. It isn't. --- diff --git a/documentation/python.py b/documentation/python.py index 15c3131a..d16a2021 100755 --- a/documentation/python.py +++ b/documentation/python.py @@ -236,7 +236,7 @@ def parse_pybind_signature(signature: str) -> Tuple[str, str, List[Tuple[str, st # Failed to parse, return an ellipsis and docs if not signature.startswith(', '): end = original_signature.find('\n') - logging.warning("cannot parse pybind11 function signature %s", original_signature[:end]) + logging.warning("cannot parse pybind11 function signature %s", original_signature[:end if end != -1 else None]) if end != -1 and len(original_signature) > end + 1 and original_signature[end + 1] == '\n': summary = extract_summary(original_signature[end + 1:]) else: @@ -258,7 +258,7 @@ def parse_pybind_signature(signature: str) -> Tuple[str, str, List[Tuple[str, st if signature and signature[0] != '\n': end = original_signature.find('\n') - logging.warning("cannot parse pybind11 function signature %s", original_signature[:end]) + logging.warning("cannot parse pybind11 function signature %s", original_signature[:end if end != -1 else None]) if end != -1 and len(original_signature) > end + 1 and original_signature[end + 1] == '\n': summary = extract_summary(original_signature[end + 1:]) else: