chiark / gitweb /
documentation/python: don't cut off the last character in a warning.
authorVladimír Vondruš <mosra@centrum.cz>
Tue, 7 May 2019 10:35:48 +0000 (12:35 +0200)
committerVladimír Vondruš <mosra@centrum.cz>
Tue, 21 May 2019 14:51:51 +0000 (16:51 +0200)
I mistakenly thought a[:-1] is the same as a[:]. It isn't.

documentation/python.py

index 15c3131a9271f46aadd40dce423bef80bbcb4bfd..d16a2021886a5de317f1a4f414acb6a2016fff59 100755 (executable)
@@ -236,7 +236,7 @@ def parse_pybind_signature(signature: str) -> Tuple[str, str, List[Tuple[str, st
         # Failed to parse, return an ellipsis and docs
         if not signature.startswith(', '):
             end = original_signature.find('\n')
-            logging.warning("cannot parse pybind11 function signature %s", original_signature[:end])
+            logging.warning("cannot parse pybind11 function signature %s", original_signature[:end if end != -1 else None])
             if end != -1 and len(original_signature) > end + 1 and original_signature[end + 1] == '\n':
                 summary = extract_summary(original_signature[end + 1:])
             else:
@@ -258,7 +258,7 @@ def parse_pybind_signature(signature: str) -> Tuple[str, str, List[Tuple[str, st
 
     if signature and signature[0] != '\n':
         end = original_signature.find('\n')
-        logging.warning("cannot parse pybind11 function signature %s", original_signature[:end])
+        logging.warning("cannot parse pybind11 function signature %s", original_signature[:end if end != -1 else None])
         if end != -1 and len(original_signature) > end + 1 and original_signature[end + 1] == '\n':
             summary = extract_summary(original_signature[end + 1:])
         else: