[git-remote-gcrypt] Useless 2nd argument of PRIVDECRYPT

Sean Whitton spwhitton at spwhitton.name
Thu Aug 11 23:36:10 BST 2022


Hello,

On Thu 11 Aug 2022 at 10:39PM +02, Lucas Cimon wrote:

> Hi!
>
> Thank you for maintaining this great project.
>
> While playing with it, I realized something strange with the internal PRIVDECRYPT
> function:
> it takes 2 arguments, and the 2nd one (the textual signers list) is never used, appart from
> the occasional error message.
>
> You'll find enclosed a patch that removes this "signers" argument from PRIVDECRYPT,
> and the resulting "git-remote-gcrypt" script works perfectly fine.
>
> It seems like the "good signature" argument passed to PRIVDECRYPT already contains
> enough information
> to check for "gcrypt.participants" signatures.

I don't think anything was attached, but regardless, can you say more
about the error messages, please?  I'd prefer not to make the change
unless we can determine for sure that the code is generate spurious
errors.

-- 
Sean Whitton



More information about the sgo-software-discuss mailing list