[PATCH 0/5] Things found while cross-compiling for Android

Mark Wooding mdw at distorted.org.uk
Thu Sep 19 19:41:07 BST 2019


I tried cross-compiling Secnet for Android ARM, on a whim.  Android has
(rather vexingly) ditched GCC, and now you have to use Clang or nothing.
Clang has a rather different set of warnings, and Secnet trips over some
of them.

My original resolution of the `log.c' format-string warnings was to just
squelch the entire warning with a `#pragma' at the top of the source
file, but I think this approach is better.

I'm less happy with the signed/unsigned comparison in `udp.c'.  Better
ideas are welcome.

The other things were actual problems, which I've fixed.

Mark Wooding (5):
  Makefile.in: Support installation from a `VPATH' build.
  Fix bizarre `if (!consttime_memeq(X, Y, N)!=0)' idioms.
  site.c (we_have_priority): Fix unintended `&&'.
  log.c: Spray extra `FORMAT(...)' attributes to muffle Clang warnings.
  udp.c: Add explicit cast to muffle bogus Clang warning.

 Makefile.in        |  2 +-
 log.c              | 14 ++++++++------
 site.c             |  6 +++---
 transform-cbcmac.c |  2 +-
 udp.c              |  2 +-
 5 files changed, 14 insertions(+), 12 deletions(-)

-- 
[mdw]




More information about the sgo-software-discuss mailing list